From c01344a0e7981c6a491689a1890638dda2a5ee1e Mon Sep 17 00:00:00 2001 From: Paul Holden Date: Tue, 10 Jan 2023 14:50:46 +0000 Subject: [PATCH] MDL-76841 tool_mobile: improve potential config issues test. Avoid certificate checking of the default test site (`example.com`), and update the assertion so we get clearer failures in the future. --- admin/tool/mobile/tests/api_test.php | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/admin/tool/mobile/tests/api_test.php b/admin/tool/mobile/tests/api_test.php index 458febc9a5d..28f9dabd2d0 100644 --- a/admin/tool/mobile/tests/api_test.php +++ b/admin/tool/mobile/tests/api_test.php @@ -59,22 +59,26 @@ class api_test extends \externallib_advanced_testcase { */ public function test_get_potential_config_issues() { global $CFG; - require_once($CFG->dirroot . '/message/lib.php'); $this->resetAfterTest(true); $this->setAdminUser(); - $CFG->userquota = '73289234723498234723423489273423497234234'; + // Set non-SSL wwwroot, to avoid spurious certificate checking. + $CFG->wwwroot = 'http://www.example.com'; $CFG->debugdisplay = 1; + set_config('debugauthdb', 1, 'auth_db'); set_config('debugdb', 1, 'enrol_database'); - $expectedissues = array('adodbdebugwarning', 'displayerrorswarning'); + // Get potential issues, obtain their keys for comparison. $issues = api::get_potential_config_issues(); - $this->assertCount(count($expectedissues), $issues); - foreach ($issues as $issue) { - $this->assertTrue(in_array($issue[0], $expectedissues)); - } + $issuekeys = array_column($issues, 0); + + $this->assertEqualsCanonicalizing([ + 'nohttpsformobilewarning', + 'adodbdebugwarning', + 'displayerrorswarning', + ], $issuekeys); } /**