From 7c7b6ffa3c5c702bda0fc6c8fde03cbb98d37d1a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Yerai=20Rodr=C3=ADguez?= Date: Fri, 9 Jan 2026 16:34:38 +0100 Subject: [PATCH] MDL-76975 admin: Move AMD dependencies to data attribute to fix overflow Since there is a 1024 length limit on arguments passed through js_call_amd(), we pass it through a HTML element dataset to avoid this limit. --- public/admin/category.php | 4 +- public/admin/settings.php | 6 +-- .../templates/settings_showhide.mustache | 51 +++++++++++++++++++ public/lib/amd/build/showhidesettings.min.js | 2 +- .../lib/amd/build/showhidesettings.min.js.map | 2 +- public/lib/amd/src/showhidesettings.js | 7 ++- ...multiselect_hide_if_admin_settingspage.php | 6 +-- 7 files changed, 64 insertions(+), 14 deletions(-) create mode 100644 public/admin/templates/settings_showhide.mustache diff --git a/public/admin/category.php b/public/admin/category.php index 803367bc772..0bdfbe0c11d 100644 --- a/public/admin/category.php +++ b/public/admin/category.php @@ -119,8 +119,8 @@ foreach ($settingspage->children as $childpage) { $outputhtml .= html_writer::tag('div', '', array('class' => 'clearer')); $outputhtml .= $setting->output_html($data); if ($childpage->has_dependencies()) { - $opts = ['dependencies' => $childpage->get_dependencies_for_javascript()]; - $PAGE->requires->js_call_amd('core/showhidesettings', 'init', [$opts]); + $context = ['dependencies' => json_encode($childpage->get_dependencies_for_javascript())]; + echo $OUTPUT->render_from_template('core_admin/settings_showhide', $context); } } $outputhtml .= html_writer::end_tag('fieldset'); diff --git a/public/admin/settings.php b/public/admin/settings.php index 48171745b3a..25ba9a556ac 100644 --- a/public/admin/settings.php +++ b/public/admin/settings.php @@ -165,10 +165,8 @@ if (empty($SITE->fullname)) { $PAGE->requires->js_call_amd('core_form/changechecker', 'watchFormById', ['adminsettings']); if ($settingspage->has_dependencies()) { - $opts = [ - 'dependencies' => $settingspage->get_dependencies_for_javascript() - ]; - $PAGE->requires->js_call_amd('core/showhidesettings', 'init', [$opts]); + $context = ['dependencies' => json_encode($settingspage->get_dependencies_for_javascript())]; + echo $OUTPUT->render_from_template('core_admin/settings_showhide', $context); } echo $OUTPUT->footer(); diff --git a/public/admin/templates/settings_showhide.mustache b/public/admin/templates/settings_showhide.mustache new file mode 100644 index 00000000000..e02d5b14ad4 --- /dev/null +++ b/public/admin/templates/settings_showhide.mustache @@ -0,0 +1,51 @@ +{{! + This file is part of Moodle - http://moodle.org/ + + Moodle is free software: you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation, either version 3 of the License, or + (at your option) any later version. + + Moodle is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with Moodle. If not, see . +}} +{{! + @template core_admin/settings_showhide + + Passes the necessary data to show/hide dependant settings. + + Context variables required for this template: + * dependencies - JSON-serialized data structure describing the dependencies between settings + + Example context (json): + { + "dependencies": { + "s__setting1":{ + "eq":[ + [ + "s__setting0" + ] + ] + }, + "s__setting2":{ + "eq":[ + [ + "s__setting1" + ] + ] + } + } + } +}} + + +{{#js}} + require(['core/showhidesettings'], function(ShowHideSettings) { + ShowHideSettings.init("settings-showhide-{{uniqid}}"); + }); +{{/js}} diff --git a/public/lib/amd/build/showhidesettings.min.js b/public/lib/amd/build/showhidesettings.min.js index da534262e30..a93f3d36804 100644 --- a/public/lib/amd/build/showhidesettings.min.js +++ b/public/lib/amd/build/showhidesettings.min.js @@ -4,6 +4,6 @@ * @copyright 2018 Davo Smith, Synergy Learning * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later */ -define("core/showhidesettings",["jquery"],(function($){var dependencies;function isCheckboxHiddenElement($el){return $el.is("input[type=hidden]")&&$el.siblings('input[type=checkbox][name="'+$el.attr("name")+'"]').length}function isCheckedRelevant($el,value){return!isCheckboxHiddenElement($el)&&!function($el,value){return $el.is("input[type=radio]")&&$el.attr("value")!==value}($el,value)}function isUncheckedRadioButton($el){return $el.is("input[type=radio]")&&!$el.prop("checked")}function isUncheckedCheckbox($el){return $el.is("input[type=checkbox]")&&!$el.prop("checked")}function isMultiSelect($el){return $el.is("select")&&$el.prop("multiple")}function multiSelectMatches($el,values){var selected=$el.val()||[];if(1===values.length&&""===values[0])return 0===selected.length;if(selected.length!==values.length)return!1;for(var i in selected)if(selected.hasOwnProperty(i)&&-1===values.indexOf(selected[i]))return!1;return!0}var depFns={notchecked:function($dependon,value){var hide=!1;return value=String(value),$dependon.each((function(idx,el){var $el=$(el);isCheckedRelevant($el,value)&&(hide=hide||!$el.prop("checked"))})),hide},checked:function($dependon,value){var hide=!1;return value=String(value),$dependon.each((function(idx,el){var $el=$(el);isCheckedRelevant($el,value)&&(hide=hide||$el.prop("checked"))})),hide},noitemselected:function($dependon){var hide=!1;return $dependon.each((function(idx,el){var $el=$(el);hide=hide||-1===$el.prop("selectedIndex")})),hide},eq:function($dependon,value){var hide=!1,hiddenVal=!1;return value=String(value),$dependon.each((function(idx,el){var $el=$(el);if(!isUncheckedRadioButton($el))if(isCheckboxHiddenElement($el))hiddenVal=$el.val()===value;else if(isUncheckedCheckbox($el))hide=hide||hiddenVal;else if(isMultiSelect($el)){var values=value.split("|");hide=multiSelectMatches($el,values)}else hide=hide||$el.val()===value})),hide},in:function($dependon,value){var hide=!1,hiddenVal=!1,values=value.split("|");return $dependon.each((function(idx,el){var $el=$(el);isUncheckedRadioButton($el)||(isCheckboxHiddenElement($el)?hiddenVal=values.indexOf($el.val())>-1:hide=isUncheckedCheckbox($el)?hide||hiddenVal:isMultiSelect($el)?function($el,values){let selected=$el.val()||[];return 0==selected.length&&selected.push(""),selected.every((element=>values.includes(element)))}($el,values):hide||values.indexOf($el.val())>-1)})),hide},defaultCondition:function($dependon,value){var hide=!1,hiddenVal=!1;return value=String(value),$dependon.each((function(idx,el){var $el=$(el);if(!isUncheckedRadioButton($el))if(isCheckboxHiddenElement($el))hiddenVal=$el.val()!==value;else if(isUncheckedCheckbox($el))hide=hide||hiddenVal;else if(isMultiSelect($el)){var values=value.split("|");hide=!multiSelectMatches($el,values)}else hide=hide||$el.val()!==value})),hide}};function getElementsByName(name){return $('[name="'+name+'"],[name^="'+name+'["]')}function updateDependencies(){var toHide={};$.each(dependencies,(function(dependonname){var dependon=getElementsByName(dependonname);$.each(dependencies[dependonname],(function(condition,values){$.each(values,(function(value,elements){var hide=function($dependon,condition,value){return"function"==typeof depFns[condition]?depFns[condition]($dependon,value):depFns.defaultCondition($dependon,value)}(dependon,condition,value);$.each(elements,(function(idx,elToHide){toHide.hasOwnProperty(elToHide)?toHide[elToHide]=toHide[elToHide]||hide:toHide[elToHide]=hide}))}))}))})),$.each(toHide,(function(elToHide,hide){getElementsByName(elToHide).each((function(idx,el){var $parent=$(el).closest(".form-item");$parent.length&&(hide?$parent.hide():$parent.show())}))}))}return{init:function(opts){dependencies=opts.dependencies,$.each(dependencies,(function(depname){var $el=getElementsByName(depname);$el.length&&$el.on("change",updateDependencies)})),updateDependencies(),$(".form-dependenton").hide()}}})); +define("core/showhidesettings",["jquery"],(function($){var dependencies;function isCheckboxHiddenElement($el){return $el.is("input[type=hidden]")&&$el.siblings('input[type=checkbox][name="'+$el.attr("name")+'"]').length}function isCheckedRelevant($el,value){return!isCheckboxHiddenElement($el)&&!function($el,value){return $el.is("input[type=radio]")&&$el.attr("value")!==value}($el,value)}function isUncheckedRadioButton($el){return $el.is("input[type=radio]")&&!$el.prop("checked")}function isUncheckedCheckbox($el){return $el.is("input[type=checkbox]")&&!$el.prop("checked")}function isMultiSelect($el){return $el.is("select")&&$el.prop("multiple")}function multiSelectMatches($el,values){var selected=$el.val()||[];if(1===values.length&&""===values[0])return 0===selected.length;if(selected.length!==values.length)return!1;for(var i in selected)if(selected.hasOwnProperty(i)&&-1===values.indexOf(selected[i]))return!1;return!0}var depFns={notchecked:function($dependon,value){var hide=!1;return value=String(value),$dependon.each((function(idx,el){var $el=$(el);isCheckedRelevant($el,value)&&(hide=hide||!$el.prop("checked"))})),hide},checked:function($dependon,value){var hide=!1;return value=String(value),$dependon.each((function(idx,el){var $el=$(el);isCheckedRelevant($el,value)&&(hide=hide||$el.prop("checked"))})),hide},noitemselected:function($dependon){var hide=!1;return $dependon.each((function(idx,el){var $el=$(el);hide=hide||-1===$el.prop("selectedIndex")})),hide},eq:function($dependon,value){var hide=!1,hiddenVal=!1;return value=String(value),$dependon.each((function(idx,el){var $el=$(el);if(!isUncheckedRadioButton($el))if(isCheckboxHiddenElement($el))hiddenVal=$el.val()===value;else if(isUncheckedCheckbox($el))hide=hide||hiddenVal;else if(isMultiSelect($el)){var values=value.split("|");hide=multiSelectMatches($el,values)}else hide=hide||$el.val()===value})),hide},in:function($dependon,value){var hide=!1,hiddenVal=!1,values=value.split("|");return $dependon.each((function(idx,el){var $el=$(el);isUncheckedRadioButton($el)||(isCheckboxHiddenElement($el)?hiddenVal=values.indexOf($el.val())>-1:hide=isUncheckedCheckbox($el)?hide||hiddenVal:isMultiSelect($el)?function($el,values){let selected=$el.val()||[];return 0==selected.length&&selected.push(""),selected.every((element=>values.includes(element)))}($el,values):hide||values.indexOf($el.val())>-1)})),hide},defaultCondition:function($dependon,value){var hide=!1,hiddenVal=!1;return value=String(value),$dependon.each((function(idx,el){var $el=$(el);if(!isUncheckedRadioButton($el))if(isCheckboxHiddenElement($el))hiddenVal=$el.val()!==value;else if(isUncheckedCheckbox($el))hide=hide||hiddenVal;else if(isMultiSelect($el)){var values=value.split("|");hide=!multiSelectMatches($el,values)}else hide=hide||$el.val()!==value})),hide}};function getElementsByName(name){return $('[name="'+name+'"],[name^="'+name+'["]')}function updateDependencies(){var toHide={};$.each(dependencies,(function(dependonname){var dependon=getElementsByName(dependonname);$.each(dependencies[dependonname],(function(condition,values){$.each(values,(function(value,elements){var hide=function($dependon,condition,value){return"function"==typeof depFns[condition]?depFns[condition]($dependon,value):depFns.defaultCondition($dependon,value)}(dependon,condition,value);$.each(elements,(function(idx,elToHide){toHide.hasOwnProperty(elToHide)?toHide[elToHide]=toHide[elToHide]||hide:toHide[elToHide]=hide}))}))}))})),$.each(toHide,(function(elToHide,hide){getElementsByName(elToHide).each((function(idx,el){var $parent=$(el).closest(".form-item");$parent.length&&(hide?$parent.hide():$parent.show())}))}))}return{init:function(dependenciesId){const dependenciesData=document.getElementById(dependenciesId).dataset.dependencies;dependenciesData&&(dependencies=JSON.parse(dependenciesData)),$.each(dependencies,(function(depname){var $el=getElementsByName(depname);$el.length&&$el.on("change",updateDependencies)})),updateDependencies(),$(".form-dependenton").hide()}}})); //# sourceMappingURL=showhidesettings.min.js.map \ No newline at end of file diff --git a/public/lib/amd/build/showhidesettings.min.js.map b/public/lib/amd/build/showhidesettings.min.js.map index fbc316c186f..9063d3db1d5 100644 --- a/public/lib/amd/build/showhidesettings.min.js.map +++ b/public/lib/amd/build/showhidesettings.min.js.map @@ -1 +1 @@ -{"version":3,"file":"showhidesettings.min.js","sources":["../src/showhidesettings.js"],"sourcesContent":["/**\n * Show/hide admin settings based on other settings selected\n *\n * @copyright 2018 Davo Smith, Synergy Learning\n * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later\n */\ndefine(['jquery'], function($) {\n var dependencies;\n\n // -------------------------------------------------\n // Support functions, used by dependency functions.\n // -------------------------------------------------\n\n /**\n * Check to see if the given element is the hidden element that makes sure checkbox\n * elements always submit a value.\n * @param {jQuery} $el\n * @returns {boolean}\n */\n function isCheckboxHiddenElement($el) {\n return ($el.is('input[type=hidden]') && $el.siblings('input[type=checkbox][name=\"' + $el.attr('name') + '\"]').length);\n }\n\n /**\n * Check to see if this is a radio button with the wrong value (i.e. a radio button from\n * the group we are interested in, but not the specific one we wanted).\n * @param {jQuery} $el\n * @param {string} value\n * @returns {boolean}\n */\n function isWrongRadioButton($el, value) {\n return ($el.is('input[type=radio]') && $el.attr('value') !== value);\n }\n\n /**\n * Is this element relevant when we're looking for checked / not checked status?\n * @param {jQuery} $el\n * @param {string} value\n * @returns {boolean}\n */\n function isCheckedRelevant($el, value) {\n return (!isCheckboxHiddenElement($el) && !isWrongRadioButton($el, value));\n }\n\n /**\n * Is this an unchecked radio button? (If it is, we want to skip it, as\n * we're only interested in the value of the radio button that is checked)\n * @param {jQuery} $el\n * @returns {boolean}\n */\n function isUncheckedRadioButton($el) {\n return ($el.is('input[type=radio]') && !$el.prop('checked'));\n }\n\n /**\n * Is this an unchecked checkbox?\n * @param {jQuery} $el\n * @returns {boolean}\n */\n function isUncheckedCheckbox($el) {\n return ($el.is('input[type=checkbox]') && !$el.prop('checked'));\n }\n\n /**\n * Is this a multi-select select element?\n * @param {jQuery} $el\n * @returns {boolean}\n */\n function isMultiSelect($el) {\n return ($el.is('select') && $el.prop('multiple'));\n }\n\n /**\n * Are the selected values of a multi-select a subset of (i.e. 'in') the list of values provided?\n * @param {jQuery} $el\n * @param {array} values\n * @returns {boolean}\n */\n function multiSelectIn($el, values) {\n let selected = $el.val() || [];\n if (selected.length == 0) {\n selected.push('');\n }\n\n // Lock/hide if the selected values are a subset of the values.\n let isSubset = selected.every(element => values.includes(element));\n return isSubset;\n }\n\n /**\n * Are the selected values of a multi-select an exact match (i.e. 'eq') to the list of values provided?\n * @param {jQuery} $el\n * @param {array} values\n * @returns {boolean}\n */\n function multiSelectMatches($el, values) {\n var selected = $el.val() || [];\n if (values.length === 1 && values[0] === '') {\n // Values array contains a single empty entry -> value was empty.\n return selected.length === 0;\n }\n if (selected.length !== values.length) {\n // Different number of expected and actual values - cannot possibly be a match.\n return false;\n }\n for (var i in selected) {\n if (selected.hasOwnProperty(i)) {\n if (values.indexOf(selected[i]) === -1) {\n return false; // Found a non-matching value - give up immediately.\n }\n }\n }\n // Didn't find a non-matching value, so we have a match.\n return true;\n }\n\n // -------------------------------\n // Specific dependency functions.\n // -------------------------------\n\n var depFns = {\n notchecked: function($dependon, value) {\n var hide = false;\n value = String(value);\n $dependon.each(function(idx, el) {\n var $el = $(el);\n if (isCheckedRelevant($el, value)) {\n hide = hide || !$el.prop('checked');\n }\n });\n return hide;\n },\n\n checked: function($dependon, value) {\n var hide = false;\n value = String(value);\n $dependon.each(function(idx, el) {\n var $el = $(el);\n if (isCheckedRelevant($el, value)) {\n hide = hide || $el.prop('checked');\n }\n });\n return hide;\n },\n\n noitemselected: function($dependon) {\n var hide = false;\n $dependon.each(function(idx, el) {\n var $el = $(el);\n hide = hide || ($el.prop('selectedIndex') === -1);\n });\n return hide;\n },\n\n eq: function($dependon, value) {\n var hide = false;\n var hiddenVal = false;\n value = String(value);\n $dependon.each(function(idx, el) {\n var $el = $(el);\n if (isUncheckedRadioButton($el)) {\n // For radio buttons, we're only interested in the one that is checked.\n return;\n }\n if (isCheckboxHiddenElement($el)) {\n // This is the hidden input that is part of the checkbox setting.\n // We will use this value, if the associated checkbox is unchecked.\n hiddenVal = ($el.val() === value);\n return;\n }\n if (isUncheckedCheckbox($el)) {\n // Checkbox is not checked - hide depends on the 'unchecked' value stored in\n // the associated hidden element, which we have already found, above.\n hide = hide || hiddenVal;\n return;\n }\n if (isMultiSelect($el)) {\n // Expect a list of values to match, separated by '|' - all of them must\n // match the values selected.\n var values = value.split('|');\n hide = multiSelectMatches($el, values);\n return;\n }\n // All other element types - just compare the value directly.\n hide = hide || ($el.val() === value);\n });\n return hide;\n },\n\n 'in': function($dependon, value) {\n var hide = false;\n var hiddenVal = false;\n var values = value.split('|');\n $dependon.each(function(idx, el) {\n var $el = $(el);\n if (isUncheckedRadioButton($el)) {\n // For radio buttons, we're only interested in the one that is checked.\n return;\n }\n if (isCheckboxHiddenElement($el)) {\n // This is the hidden input that is part of the checkbox setting.\n // We will use this value, if the associated checkbox is unchecked.\n hiddenVal = (values.indexOf($el.val()) > -1);\n return;\n }\n if (isUncheckedCheckbox($el)) {\n // Checkbox is not checked - hide depends on the 'unchecked' value stored in\n // the associated hidden element, which we have already found, above.\n hide = hide || hiddenVal;\n return;\n }\n if (isMultiSelect($el)) {\n // For multiselect, we check to see if the selected values are a subset of the list of values provided.\n hide = multiSelectIn($el, values);\n return;\n }\n // All other element types - check to see if the value is in the list.\n hide = hide || (values.indexOf($el.val()) > -1);\n });\n return hide;\n },\n\n defaultCondition: function($dependon, value) { // Not equal.\n var hide = false;\n var hiddenVal = false;\n value = String(value);\n $dependon.each(function(idx, el) {\n var $el = $(el);\n if (isUncheckedRadioButton($el)) {\n // For radio buttons, we're only interested in the one that is checked.\n return;\n }\n if (isCheckboxHiddenElement($el)) {\n // This is the hidden input that is part of the checkbox setting.\n // We will use this value, if the associated checkbox is unchecked.\n hiddenVal = ($el.val() !== value);\n return;\n }\n if (isUncheckedCheckbox($el)) {\n // Checkbox is not checked - hide depends on the 'unchecked' value stored in\n // the associated hidden element, which we have already found, above.\n hide = hide || hiddenVal;\n return;\n }\n if (isMultiSelect($el)) {\n // Expect a list of values to match, separated by '|' - all of them must\n // match the values selected to *not* hide the element.\n var values = value.split('|');\n hide = !multiSelectMatches($el, values);\n return;\n }\n // All other element types - just compare the value directly.\n hide = hide || ($el.val() !== value);\n });\n return hide;\n }\n };\n\n /**\n * Find the element with the given name\n * @param {String} name\n * @returns {*|jQuery|HTMLElement}\n */\n function getElementsByName(name) {\n // For the array elements, we use [name^=\"something[\"] to find the elements that their name begins with 'something['/\n // This is to find both name = 'something[]' and name='something[index]'.\n return $('[name=\"' + name + '\"],[name^=\"' + name + '[\"]');\n }\n\n /**\n * Check to see whether a particular condition is met\n * @param {*|jQuery|HTMLElement} $dependon\n * @param {String} condition\n * @param {mixed} value\n * @returns {Boolean}\n */\n function checkDependency($dependon, condition, value) {\n if (typeof depFns[condition] === \"function\") {\n return depFns[condition]($dependon, value);\n }\n return depFns.defaultCondition($dependon, value);\n }\n\n /**\n * Show / hide the elements that depend on some elements.\n */\n function updateDependencies() {\n // Process all dependency conditions.\n var toHide = {};\n $.each(dependencies, function(dependonname) {\n var dependon = getElementsByName(dependonname);\n $.each(dependencies[dependonname], function(condition, values) {\n $.each(values, function(value, elements) {\n var hide = checkDependency(dependon, condition, value);\n $.each(elements, function(idx, elToHide) {\n if (toHide.hasOwnProperty(elToHide)) {\n toHide[elToHide] = toHide[elToHide] || hide;\n } else {\n toHide[elToHide] = hide;\n }\n });\n });\n });\n });\n\n // Update the hidden status of all relevant elements.\n $.each(toHide, function(elToHide, hide) {\n getElementsByName(elToHide).each(function(idx, el) {\n var $parent = $(el).closest('.form-item');\n if ($parent.length) {\n if (hide) {\n $parent.hide();\n } else {\n $parent.show();\n }\n }\n });\n });\n }\n\n /**\n * Initialise the event handlers.\n */\n function initHandlers() {\n $.each(dependencies, function(depname) {\n var $el = getElementsByName(depname);\n if ($el.length) {\n $el.on('change', updateDependencies);\n }\n });\n updateDependencies();\n }\n\n /**\n * Hide the 'this setting may be hidden' messages.\n */\n function hideDependencyInfo() {\n $('.form-dependenton').hide();\n }\n\n return {\n init: function(opts) {\n dependencies = opts.dependencies;\n initHandlers();\n hideDependencyInfo();\n }\n };\n});\n"],"names":["define","$","dependencies","isCheckboxHiddenElement","$el","is","siblings","attr","length","isCheckedRelevant","value","isWrongRadioButton","isUncheckedRadioButton","prop","isUncheckedCheckbox","isMultiSelect","multiSelectMatches","values","selected","val","i","hasOwnProperty","indexOf","depFns","notchecked","$dependon","hide","String","each","idx","el","checked","noitemselected","eq","hiddenVal","split","push","every","element","includes","multiSelectIn","defaultCondition","getElementsByName","name","updateDependencies","toHide","dependonname","dependon","condition","elements","checkDependency","elToHide","$parent","closest","show","init","opts","depname","on"],"mappings":";;;;;;AAMAA,+BAAO,CAAC,WAAW,SAASC,OACpBC,sBAYKC,wBAAwBC,YACrBA,IAAIC,GAAG,uBAAyBD,IAAIE,SAAS,8BAAgCF,IAAIG,KAAK,QAAU,MAAMC,gBAoBzGC,kBAAkBL,IAAKM,cACnBP,wBAAwBC,gBAXTA,IAAKM,cACrBN,IAAIC,GAAG,sBAAwBD,IAAIG,KAAK,WAAaG,MAUnBC,CAAmBP,IAAKM,gBAS7DE,uBAAuBR,YACpBA,IAAIC,GAAG,uBAAyBD,IAAIS,KAAK,oBAQ5CC,oBAAoBV,YACjBA,IAAIC,GAAG,0BAA4BD,IAAIS,KAAK,oBAQ/CE,cAAcX,YACXA,IAAIC,GAAG,WAAaD,IAAIS,KAAK,qBA0BhCG,mBAAmBZ,IAAKa,YACzBC,SAAWd,IAAIe,OAAS,MACN,IAAlBF,OAAOT,QAA8B,KAAdS,OAAO,UAEH,IAApBC,SAASV,UAEhBU,SAASV,SAAWS,OAAOT,cAEpB,MAEN,IAAIY,KAAKF,YACNA,SAASG,eAAeD,KACa,IAAjCH,OAAOK,QAAQJ,SAASE,WACjB,SAKZ,MAOPG,OAAS,CACTC,WAAY,SAASC,UAAWf,WACxBgB,MAAO,SACXhB,MAAQiB,OAAOjB,OACfe,UAAUG,MAAK,SAASC,IAAKC,QACrB1B,IAAMH,EAAE6B,IACRrB,kBAAkBL,IAAKM,SACvBgB,KAAOA,OAAStB,IAAIS,KAAK,eAG1Ba,MAGXK,QAAS,SAASN,UAAWf,WACrBgB,MAAO,SACXhB,MAAQiB,OAAOjB,OACfe,UAAUG,MAAK,SAASC,IAAKC,QACrB1B,IAAMH,EAAE6B,IACRrB,kBAAkBL,IAAKM,SACvBgB,KAAOA,MAAQtB,IAAIS,KAAK,eAGzBa,MAGXM,eAAgB,SAASP,eACjBC,MAAO,SACXD,UAAUG,MAAK,SAASC,IAAKC,QACrB1B,IAAMH,EAAE6B,IACZJ,KAAOA,OAAwC,IAA/BtB,IAAIS,KAAK,oBAEtBa,MAGXO,GAAI,SAASR,UAAWf,WAChBgB,MAAO,EACPQ,WAAY,SAChBxB,MAAQiB,OAAOjB,OACfe,UAAUG,MAAK,SAASC,IAAKC,QACrB1B,IAAMH,EAAE6B,QACRlB,uBAAuBR,QAIvBD,wBAAwBC,KAGxB8B,UAAa9B,IAAIe,QAAUT,cAG3BI,oBAAoBV,KAGpBsB,KAAOA,MAAQQ,kBAGfnB,cAAcX,UAGVa,OAASP,MAAMyB,MAAM,KACzBT,KAAOV,mBAAmBZ,IAAKa,aAInCS,KAAOA,MAAStB,IAAIe,QAAUT,SAE3BgB,SAGL,SAASD,UAAWf,WAClBgB,MAAO,EACPQ,WAAY,EACZjB,OAASP,MAAMyB,MAAM,YACzBV,UAAUG,MAAK,SAASC,IAAKC,QACrB1B,IAAMH,EAAE6B,IACRlB,uBAAuBR,OAIvBD,wBAAwBC,KAGxB8B,UAAajB,OAAOK,QAAQlB,IAAIe,QAAU,EAM1CO,KAHAZ,oBAAoBV,KAGbsB,MAAQQ,UAGfnB,cAAcX,cArIPA,IAAKa,YACpBC,SAAWd,IAAIe,OAAS,UACL,GAAnBD,SAASV,QACTU,SAASkB,KAAK,IAIHlB,SAASmB,OAAMC,SAAWrB,OAAOsB,SAASD,WAgItCE,CAAcpC,IAAKa,QAIvBS,MAAST,OAAOK,QAAQlB,IAAIe,QAAU,MAE1CO,MAGXe,iBAAkB,SAAShB,UAAWf,WAC9BgB,MAAO,EACPQ,WAAY,SAChBxB,MAAQiB,OAAOjB,OACfe,UAAUG,MAAK,SAASC,IAAKC,QACrB1B,IAAMH,EAAE6B,QACRlB,uBAAuBR,QAIvBD,wBAAwBC,KAGxB8B,UAAa9B,IAAIe,QAAUT,cAG3BI,oBAAoBV,KAGpBsB,KAAOA,MAAQQ,kBAGfnB,cAAcX,UAGVa,OAASP,MAAMyB,MAAM,KACzBT,MAAQV,mBAAmBZ,IAAKa,aAIpCS,KAAOA,MAAStB,IAAIe,QAAUT,SAE3BgB,gBASNgB,kBAAkBC,aAGhB1C,EAAE,UAAY0C,KAAO,cAAgBA,KAAO,gBAoB9CC,yBAEDC,OAAS,GACb5C,EAAE2B,KAAK1B,cAAc,SAAS4C,kBACtBC,SAAWL,kBAAkBI,cACjC7C,EAAE2B,KAAK1B,aAAa4C,eAAe,SAASE,UAAW/B,QACnDhB,EAAE2B,KAAKX,QAAQ,SAASP,MAAOuC,cACvBvB,cAjBKD,UAAWuB,UAAWtC,aACV,mBAAtBa,OAAOyB,WACPzB,OAAOyB,WAAWvB,UAAWf,OAEjCa,OAAOkB,iBAAiBhB,UAAWf,OAanBwC,CAAgBH,SAAUC,UAAWtC,OAChDT,EAAE2B,KAAKqB,UAAU,SAASpB,IAAKsB,UACvBN,OAAOxB,eAAe8B,UACtBN,OAAOM,UAAYN,OAAOM,WAAazB,KAEvCmB,OAAOM,UAAYzB,iBAQvCzB,EAAE2B,KAAKiB,QAAQ,SAASM,SAAUzB,MAC9BgB,kBAAkBS,UAAUvB,MAAK,SAASC,IAAKC,QACvCsB,QAAUnD,EAAE6B,IAAIuB,QAAQ,cACxBD,QAAQ5C,SACJkB,KACA0B,QAAQ1B,OAER0B,QAAQE,oBA2BrB,CACHC,KAAM,SAASC,MACXtD,aAAesD,KAAKtD,aAlBxBD,EAAE2B,KAAK1B,cAAc,SAASuD,aACtBrD,IAAMsC,kBAAkBe,SACxBrD,IAAII,QACJJ,IAAIsD,GAAG,SAAUd,uBAGzBA,qBAOA3C,EAAE,qBAAqByB"} \ No newline at end of file +{"version":3,"file":"showhidesettings.min.js","sources":["../src/showhidesettings.js"],"sourcesContent":["/**\n * Show/hide admin settings based on other settings selected\n *\n * @copyright 2018 Davo Smith, Synergy Learning\n * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later\n */\ndefine(['jquery'], function($) {\n var dependencies;\n\n // -------------------------------------------------\n // Support functions, used by dependency functions.\n // -------------------------------------------------\n\n /**\n * Check to see if the given element is the hidden element that makes sure checkbox\n * elements always submit a value.\n * @param {jQuery} $el\n * @returns {boolean}\n */\n function isCheckboxHiddenElement($el) {\n return ($el.is('input[type=hidden]') && $el.siblings('input[type=checkbox][name=\"' + $el.attr('name') + '\"]').length);\n }\n\n /**\n * Check to see if this is a radio button with the wrong value (i.e. a radio button from\n * the group we are interested in, but not the specific one we wanted).\n * @param {jQuery} $el\n * @param {string} value\n * @returns {boolean}\n */\n function isWrongRadioButton($el, value) {\n return ($el.is('input[type=radio]') && $el.attr('value') !== value);\n }\n\n /**\n * Is this element relevant when we're looking for checked / not checked status?\n * @param {jQuery} $el\n * @param {string} value\n * @returns {boolean}\n */\n function isCheckedRelevant($el, value) {\n return (!isCheckboxHiddenElement($el) && !isWrongRadioButton($el, value));\n }\n\n /**\n * Is this an unchecked radio button? (If it is, we want to skip it, as\n * we're only interested in the value of the radio button that is checked)\n * @param {jQuery} $el\n * @returns {boolean}\n */\n function isUncheckedRadioButton($el) {\n return ($el.is('input[type=radio]') && !$el.prop('checked'));\n }\n\n /**\n * Is this an unchecked checkbox?\n * @param {jQuery} $el\n * @returns {boolean}\n */\n function isUncheckedCheckbox($el) {\n return ($el.is('input[type=checkbox]') && !$el.prop('checked'));\n }\n\n /**\n * Is this a multi-select select element?\n * @param {jQuery} $el\n * @returns {boolean}\n */\n function isMultiSelect($el) {\n return ($el.is('select') && $el.prop('multiple'));\n }\n\n /**\n * Are the selected values of a multi-select a subset of (i.e. 'in') the list of values provided?\n * @param {jQuery} $el\n * @param {array} values\n * @returns {boolean}\n */\n function multiSelectIn($el, values) {\n let selected = $el.val() || [];\n if (selected.length == 0) {\n selected.push('');\n }\n\n // Lock/hide if the selected values are a subset of the values.\n let isSubset = selected.every(element => values.includes(element));\n return isSubset;\n }\n\n /**\n * Are the selected values of a multi-select an exact match (i.e. 'eq') to the list of values provided?\n * @param {jQuery} $el\n * @param {array} values\n * @returns {boolean}\n */\n function multiSelectMatches($el, values) {\n var selected = $el.val() || [];\n if (values.length === 1 && values[0] === '') {\n // Values array contains a single empty entry -> value was empty.\n return selected.length === 0;\n }\n if (selected.length !== values.length) {\n // Different number of expected and actual values - cannot possibly be a match.\n return false;\n }\n for (var i in selected) {\n if (selected.hasOwnProperty(i)) {\n if (values.indexOf(selected[i]) === -1) {\n return false; // Found a non-matching value - give up immediately.\n }\n }\n }\n // Didn't find a non-matching value, so we have a match.\n return true;\n }\n\n // -------------------------------\n // Specific dependency functions.\n // -------------------------------\n\n var depFns = {\n notchecked: function($dependon, value) {\n var hide = false;\n value = String(value);\n $dependon.each(function(idx, el) {\n var $el = $(el);\n if (isCheckedRelevant($el, value)) {\n hide = hide || !$el.prop('checked');\n }\n });\n return hide;\n },\n\n checked: function($dependon, value) {\n var hide = false;\n value = String(value);\n $dependon.each(function(idx, el) {\n var $el = $(el);\n if (isCheckedRelevant($el, value)) {\n hide = hide || $el.prop('checked');\n }\n });\n return hide;\n },\n\n noitemselected: function($dependon) {\n var hide = false;\n $dependon.each(function(idx, el) {\n var $el = $(el);\n hide = hide || ($el.prop('selectedIndex') === -1);\n });\n return hide;\n },\n\n eq: function($dependon, value) {\n var hide = false;\n var hiddenVal = false;\n value = String(value);\n $dependon.each(function(idx, el) {\n var $el = $(el);\n if (isUncheckedRadioButton($el)) {\n // For radio buttons, we're only interested in the one that is checked.\n return;\n }\n if (isCheckboxHiddenElement($el)) {\n // This is the hidden input that is part of the checkbox setting.\n // We will use this value, if the associated checkbox is unchecked.\n hiddenVal = ($el.val() === value);\n return;\n }\n if (isUncheckedCheckbox($el)) {\n // Checkbox is not checked - hide depends on the 'unchecked' value stored in\n // the associated hidden element, which we have already found, above.\n hide = hide || hiddenVal;\n return;\n }\n if (isMultiSelect($el)) {\n // Expect a list of values to match, separated by '|' - all of them must\n // match the values selected.\n var values = value.split('|');\n hide = multiSelectMatches($el, values);\n return;\n }\n // All other element types - just compare the value directly.\n hide = hide || ($el.val() === value);\n });\n return hide;\n },\n\n 'in': function($dependon, value) {\n var hide = false;\n var hiddenVal = false;\n var values = value.split('|');\n $dependon.each(function(idx, el) {\n var $el = $(el);\n if (isUncheckedRadioButton($el)) {\n // For radio buttons, we're only interested in the one that is checked.\n return;\n }\n if (isCheckboxHiddenElement($el)) {\n // This is the hidden input that is part of the checkbox setting.\n // We will use this value, if the associated checkbox is unchecked.\n hiddenVal = (values.indexOf($el.val()) > -1);\n return;\n }\n if (isUncheckedCheckbox($el)) {\n // Checkbox is not checked - hide depends on the 'unchecked' value stored in\n // the associated hidden element, which we have already found, above.\n hide = hide || hiddenVal;\n return;\n }\n if (isMultiSelect($el)) {\n // For multiselect, we check to see if the selected values are a subset of the list of values provided.\n hide = multiSelectIn($el, values);\n return;\n }\n // All other element types - check to see if the value is in the list.\n hide = hide || (values.indexOf($el.val()) > -1);\n });\n return hide;\n },\n\n defaultCondition: function($dependon, value) { // Not equal.\n var hide = false;\n var hiddenVal = false;\n value = String(value);\n $dependon.each(function(idx, el) {\n var $el = $(el);\n if (isUncheckedRadioButton($el)) {\n // For radio buttons, we're only interested in the one that is checked.\n return;\n }\n if (isCheckboxHiddenElement($el)) {\n // This is the hidden input that is part of the checkbox setting.\n // We will use this value, if the associated checkbox is unchecked.\n hiddenVal = ($el.val() !== value);\n return;\n }\n if (isUncheckedCheckbox($el)) {\n // Checkbox is not checked - hide depends on the 'unchecked' value stored in\n // the associated hidden element, which we have already found, above.\n hide = hide || hiddenVal;\n return;\n }\n if (isMultiSelect($el)) {\n // Expect a list of values to match, separated by '|' - all of them must\n // match the values selected to *not* hide the element.\n var values = value.split('|');\n hide = !multiSelectMatches($el, values);\n return;\n }\n // All other element types - just compare the value directly.\n hide = hide || ($el.val() !== value);\n });\n return hide;\n }\n };\n\n /**\n * Find the element with the given name\n * @param {String} name\n * @returns {*|jQuery|HTMLElement}\n */\n function getElementsByName(name) {\n // For the array elements, we use [name^=\"something[\"] to find the elements that their name begins with 'something['/\n // This is to find both name = 'something[]' and name='something[index]'.\n return $('[name=\"' + name + '\"],[name^=\"' + name + '[\"]');\n }\n\n /**\n * Check to see whether a particular condition is met\n * @param {*|jQuery|HTMLElement} $dependon\n * @param {String} condition\n * @param {mixed} value\n * @returns {Boolean}\n */\n function checkDependency($dependon, condition, value) {\n if (typeof depFns[condition] === \"function\") {\n return depFns[condition]($dependon, value);\n }\n return depFns.defaultCondition($dependon, value);\n }\n\n /**\n * Show / hide the elements that depend on some elements.\n */\n function updateDependencies() {\n // Process all dependency conditions.\n var toHide = {};\n $.each(dependencies, function(dependonname) {\n var dependon = getElementsByName(dependonname);\n $.each(dependencies[dependonname], function(condition, values) {\n $.each(values, function(value, elements) {\n var hide = checkDependency(dependon, condition, value);\n $.each(elements, function(idx, elToHide) {\n if (toHide.hasOwnProperty(elToHide)) {\n toHide[elToHide] = toHide[elToHide] || hide;\n } else {\n toHide[elToHide] = hide;\n }\n });\n });\n });\n });\n\n // Update the hidden status of all relevant elements.\n $.each(toHide, function(elToHide, hide) {\n getElementsByName(elToHide).each(function(idx, el) {\n var $parent = $(el).closest('.form-item');\n if ($parent.length) {\n if (hide) {\n $parent.hide();\n } else {\n $parent.show();\n }\n }\n });\n });\n }\n\n /**\n * Initialise the event handlers.\n */\n function initHandlers() {\n $.each(dependencies, function(depname) {\n var $el = getElementsByName(depname);\n if ($el.length) {\n $el.on('change', updateDependencies);\n }\n });\n updateDependencies();\n }\n\n /**\n * Hide the 'this setting may be hidden' messages.\n */\n function hideDependencyInfo() {\n $('.form-dependenton').hide();\n }\n\n return {\n init: function(dependenciesId) {\n const dependenciesData = document.getElementById(dependenciesId).dataset.dependencies;\n if (dependenciesData) {\n dependencies = JSON.parse(dependenciesData);\n }\n initHandlers();\n hideDependencyInfo();\n }\n };\n});\n"],"names":["define","$","dependencies","isCheckboxHiddenElement","$el","is","siblings","attr","length","isCheckedRelevant","value","isWrongRadioButton","isUncheckedRadioButton","prop","isUncheckedCheckbox","isMultiSelect","multiSelectMatches","values","selected","val","i","hasOwnProperty","indexOf","depFns","notchecked","$dependon","hide","String","each","idx","el","checked","noitemselected","eq","hiddenVal","split","push","every","element","includes","multiSelectIn","defaultCondition","getElementsByName","name","updateDependencies","toHide","dependonname","dependon","condition","elements","checkDependency","elToHide","$parent","closest","show","init","dependenciesId","dependenciesData","document","getElementById","dataset","JSON","parse","depname","on"],"mappings":";;;;;;AAMAA,+BAAO,CAAC,WAAW,SAASC,OACpBC,sBAYKC,wBAAwBC,YACrBA,IAAIC,GAAG,uBAAyBD,IAAIE,SAAS,8BAAgCF,IAAIG,KAAK,QAAU,MAAMC,gBAoBzGC,kBAAkBL,IAAKM,cACnBP,wBAAwBC,gBAXTA,IAAKM,cACrBN,IAAIC,GAAG,sBAAwBD,IAAIG,KAAK,WAAaG,MAUnBC,CAAmBP,IAAKM,gBAS7DE,uBAAuBR,YACpBA,IAAIC,GAAG,uBAAyBD,IAAIS,KAAK,oBAQ5CC,oBAAoBV,YACjBA,IAAIC,GAAG,0BAA4BD,IAAIS,KAAK,oBAQ/CE,cAAcX,YACXA,IAAIC,GAAG,WAAaD,IAAIS,KAAK,qBA0BhCG,mBAAmBZ,IAAKa,YACzBC,SAAWd,IAAIe,OAAS,MACN,IAAlBF,OAAOT,QAA8B,KAAdS,OAAO,UAEH,IAApBC,SAASV,UAEhBU,SAASV,SAAWS,OAAOT,cAEpB,MAEN,IAAIY,KAAKF,YACNA,SAASG,eAAeD,KACa,IAAjCH,OAAOK,QAAQJ,SAASE,WACjB,SAKZ,MAOPG,OAAS,CACTC,WAAY,SAASC,UAAWf,WACxBgB,MAAO,SACXhB,MAAQiB,OAAOjB,OACfe,UAAUG,MAAK,SAASC,IAAKC,QACrB1B,IAAMH,EAAE6B,IACRrB,kBAAkBL,IAAKM,SACvBgB,KAAOA,OAAStB,IAAIS,KAAK,eAG1Ba,MAGXK,QAAS,SAASN,UAAWf,WACrBgB,MAAO,SACXhB,MAAQiB,OAAOjB,OACfe,UAAUG,MAAK,SAASC,IAAKC,QACrB1B,IAAMH,EAAE6B,IACRrB,kBAAkBL,IAAKM,SACvBgB,KAAOA,MAAQtB,IAAIS,KAAK,eAGzBa,MAGXM,eAAgB,SAASP,eACjBC,MAAO,SACXD,UAAUG,MAAK,SAASC,IAAKC,QACrB1B,IAAMH,EAAE6B,IACZJ,KAAOA,OAAwC,IAA/BtB,IAAIS,KAAK,oBAEtBa,MAGXO,GAAI,SAASR,UAAWf,WAChBgB,MAAO,EACPQ,WAAY,SAChBxB,MAAQiB,OAAOjB,OACfe,UAAUG,MAAK,SAASC,IAAKC,QACrB1B,IAAMH,EAAE6B,QACRlB,uBAAuBR,QAIvBD,wBAAwBC,KAGxB8B,UAAa9B,IAAIe,QAAUT,cAG3BI,oBAAoBV,KAGpBsB,KAAOA,MAAQQ,kBAGfnB,cAAcX,UAGVa,OAASP,MAAMyB,MAAM,KACzBT,KAAOV,mBAAmBZ,IAAKa,aAInCS,KAAOA,MAAStB,IAAIe,QAAUT,SAE3BgB,SAGL,SAASD,UAAWf,WAClBgB,MAAO,EACPQ,WAAY,EACZjB,OAASP,MAAMyB,MAAM,YACzBV,UAAUG,MAAK,SAASC,IAAKC,QACrB1B,IAAMH,EAAE6B,IACRlB,uBAAuBR,OAIvBD,wBAAwBC,KAGxB8B,UAAajB,OAAOK,QAAQlB,IAAIe,QAAU,EAM1CO,KAHAZ,oBAAoBV,KAGbsB,MAAQQ,UAGfnB,cAAcX,cArIPA,IAAKa,YACpBC,SAAWd,IAAIe,OAAS,UACL,GAAnBD,SAASV,QACTU,SAASkB,KAAK,IAIHlB,SAASmB,OAAMC,SAAWrB,OAAOsB,SAASD,WAgItCE,CAAcpC,IAAKa,QAIvBS,MAAST,OAAOK,QAAQlB,IAAIe,QAAU,MAE1CO,MAGXe,iBAAkB,SAAShB,UAAWf,WAC9BgB,MAAO,EACPQ,WAAY,SAChBxB,MAAQiB,OAAOjB,OACfe,UAAUG,MAAK,SAASC,IAAKC,QACrB1B,IAAMH,EAAE6B,QACRlB,uBAAuBR,QAIvBD,wBAAwBC,KAGxB8B,UAAa9B,IAAIe,QAAUT,cAG3BI,oBAAoBV,KAGpBsB,KAAOA,MAAQQ,kBAGfnB,cAAcX,UAGVa,OAASP,MAAMyB,MAAM,KACzBT,MAAQV,mBAAmBZ,IAAKa,aAIpCS,KAAOA,MAAStB,IAAIe,QAAUT,SAE3BgB,gBASNgB,kBAAkBC,aAGhB1C,EAAE,UAAY0C,KAAO,cAAgBA,KAAO,gBAoB9CC,yBAEDC,OAAS,GACb5C,EAAE2B,KAAK1B,cAAc,SAAS4C,kBACtBC,SAAWL,kBAAkBI,cACjC7C,EAAE2B,KAAK1B,aAAa4C,eAAe,SAASE,UAAW/B,QACnDhB,EAAE2B,KAAKX,QAAQ,SAASP,MAAOuC,cACvBvB,cAjBKD,UAAWuB,UAAWtC,aACV,mBAAtBa,OAAOyB,WACPzB,OAAOyB,WAAWvB,UAAWf,OAEjCa,OAAOkB,iBAAiBhB,UAAWf,OAanBwC,CAAgBH,SAAUC,UAAWtC,OAChDT,EAAE2B,KAAKqB,UAAU,SAASpB,IAAKsB,UACvBN,OAAOxB,eAAe8B,UACtBN,OAAOM,UAAYN,OAAOM,WAAazB,KAEvCmB,OAAOM,UAAYzB,iBAQvCzB,EAAE2B,KAAKiB,QAAQ,SAASM,SAAUzB,MAC9BgB,kBAAkBS,UAAUvB,MAAK,SAASC,IAAKC,QACvCsB,QAAUnD,EAAE6B,IAAIuB,QAAQ,cACxBD,QAAQ5C,SACJkB,KACA0B,QAAQ1B,OAER0B,QAAQE,oBA2BrB,CACHC,KAAM,SAASC,sBACLC,iBAAmBC,SAASC,eAAeH,gBAAgBI,QAAQ1D,aACrEuD,mBACAvD,aAAe2D,KAAKC,MAAML,mBApBlCxD,EAAE2B,KAAK1B,cAAc,SAAS6D,aACtB3D,IAAMsC,kBAAkBqB,SACxB3D,IAAII,QACJJ,IAAI4D,GAAG,SAAUpB,uBAGzBA,qBAOA3C,EAAE,qBAAqByB"} \ No newline at end of file diff --git a/public/lib/amd/src/showhidesettings.js b/public/lib/amd/src/showhidesettings.js index ca8ccbe4355..835d1c7304e 100644 --- a/public/lib/amd/src/showhidesettings.js +++ b/public/lib/amd/src/showhidesettings.js @@ -339,8 +339,11 @@ define(['jquery'], function($) { } return { - init: function(opts) { - dependencies = opts.dependencies; + init: function(dependenciesId) { + const dependenciesData = document.getElementById(dependenciesId).dataset.dependencies; + if (dependenciesData) { + dependencies = JSON.parse(dependenciesData); + } initHandlers(); hideDependencyInfo(); } diff --git a/public/lib/tests/behat/fixtures/multiselect_hide_if_admin_settingspage.php b/public/lib/tests/behat/fixtures/multiselect_hide_if_admin_settingspage.php index 1c9d43d229c..9e644a992be 100644 --- a/public/lib/tests/behat/fixtures/multiselect_hide_if_admin_settingspage.php +++ b/public/lib/tests/behat/fixtures/multiselect_hide_if_admin_settingspage.php @@ -70,9 +70,7 @@ $context = [ ]; echo $OUTPUT->render_from_template('core_admin/settings', $context); -$opts = [ - 'dependencies' => $settings->get_dependencies_for_javascript(), -]; -$PAGE->requires->js_call_amd('core/showhidesettings', 'init', [$opts]); +$context = ['dependencies' => json_encode($settings->get_dependencies_for_javascript())]; +echo $OUTPUT->render_from_template('core_admin/settings_showhide', $context); echo $OUTPUT->footer();