From 7c1cb3bf5a8a81605162019149ef975298d4f6ff Mon Sep 17 00:00:00 2001
From: Juan Leyva <juanleyvadelgado@gmail.com>
Date: Tue, 4 Oct 2016 12:12:16 +0100
Subject: [PATCH] MDL-54866 tool_mobile: Rename WS get_site_public_settings

---
 admin/tool/mobile/classes/api.php            |  2 +-
 admin/tool/mobile/classes/external.php       | 12 ++++++------
 admin/tool/mobile/db/services.php            |  4 ++--
 admin/tool/mobile/tests/externallib_test.php | 10 +++++-----
 4 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/admin/tool/mobile/classes/api.php b/admin/tool/mobile/classes/api.php
index 5bc279b2ff8..192b79e79a9 100644
--- a/admin/tool/mobile/classes/api.php
+++ b/admin/tool/mobile/classes/api.php
@@ -96,7 +96,7 @@ class api {
      *
      * @return array with the settings and warnings
      */
-    public static function get_site_public_settings() {
+    public static function get_public_config() {
         global $CFG, $SITE, $PAGE;
 
         $context = context_system::instance();
diff --git a/admin/tool/mobile/classes/external.php b/admin/tool/mobile/classes/external.php
index 293b48067fe..8058a867619 100644
--- a/admin/tool/mobile/classes/external.php
+++ b/admin/tool/mobile/classes/external.php
@@ -96,12 +96,12 @@ class external extends external_api {
     }
 
     /**
-     * Returns description of get_site_public_settings() parameters.
+     * Returns description of get_public_config() parameters.
      *
      * @return external_function_parameters
      * @since  Moodle 3.2
      */
-    public static function get_site_public_settings_parameters() {
+    public static function get_public_config_parameters() {
         return new external_function_parameters(array());
     }
 
@@ -111,19 +111,19 @@ class external extends external_api {
      * @return array with the settings and warnings
      * @since  Moodle 3.2
      */
-    public static function get_site_public_settings() {
-        $result = api::get_site_public_settings();
+    public static function get_public_config() {
+        $result = api::get_public_config();
         $result['warnings'] = array();
         return $result;
     }
 
     /**
-     * Returns description of get_site_public_settings() result value.
+     * Returns description of get_public_config() result value.
      *
      * @return external_description
      * @since  Moodle 3.2
      */
-    public static function get_site_public_settings_returns() {
+    public static function get_public_config_returns() {
         return new external_single_structure(
             array(
                 'wwwroot' => new external_value(PARAM_RAW, 'Site URL.'),
diff --git a/admin/tool/mobile/db/services.php b/admin/tool/mobile/db/services.php
index 6aa1890583d..13ac5b01163 100644
--- a/admin/tool/mobile/db/services.php
+++ b/admin/tool/mobile/db/services.php
@@ -33,9 +33,9 @@ $functions = array(
         'services'    => array(MOODLE_OFFICIAL_MOBILE_SERVICE)
     ),
 
-    'tool_mobile_get_site_public_settings' => array(
+    'tool_mobile_get_public_config' => array(
         'classname'   => 'tool_mobile\external',
-        'methodname'  => 'get_site_public_settings',
+        'methodname'  => 'get_public_config',
         'description' => 'Returns a list of the site public settings, those not requiring authentication.',
         'type'        => 'read',
         'services'    => array(MOODLE_OFFICIAL_MOBILE_SERVICE),
diff --git a/admin/tool/mobile/tests/externallib_test.php b/admin/tool/mobile/tests/externallib_test.php
index 3d230a4489d..3fd3b3a581c 100644
--- a/admin/tool/mobile/tests/externallib_test.php
+++ b/admin/tool/mobile/tests/externallib_test.php
@@ -55,12 +55,12 @@ class tool_mobile_external_testcase extends externallib_advanced_testcase {
         $this->assertTrue(is_array($result['plugins']));
     }
 
-    public function test_get_site_public_settings() {
+    public function test_get_public_config() {
         global $CFG, $SITE;
 
         $this->resetAfterTest(true);
-        $result = external::get_site_public_settings();
-        $result = external_api::clean_returnvalue(external::get_site_public_settings_returns(), $result);
+        $result = external::get_public_config();
+        $result = external_api::clean_returnvalue(external::get_public_config_returns(), $result);
 
         // Test default values.
         $context = context_system::instance();
@@ -95,8 +95,8 @@ class tool_mobile_external_testcase extends externallib_advanced_testcase {
         $expected['typeoflogin'] = api::LOGIN_VIA_BROWSER;
         $expected['launchurl'] = "$CFG->wwwroot/$CFG->admin/tool/mobile/launch.php";;
 
-        $result = external::get_site_public_settings();
-        $result = external_api::clean_returnvalue(external::get_site_public_settings_returns(), $result);
+        $result = external::get_public_config();
+        $result = external_api::clean_returnvalue(external::get_public_config_returns(), $result);
         $this->assertEquals($expected, $result);
     }