From b7d5895d6eb07de7e2b26a6d6fa41086d58b8f23 Mon Sep 17 00:00:00 2001 From: David Woloszyn Date: Thu, 13 Mar 2025 11:22:22 +1100 Subject: [PATCH 1/2] MDL-84751 aiprovider_openai: Fix settings help spacing --- ai/provider/openai/classes/hook_listener.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/ai/provider/openai/classes/hook_listener.php b/ai/provider/openai/classes/hook_listener.php index eed5d0bd750..4d2ef9bb99d 100644 --- a/ai/provider/openai/classes/hook_listener.php +++ b/ai/provider/openai/classes/hook_listener.php @@ -82,7 +82,8 @@ class hook_listener { if ($model == 'custom') { $mform->addElement('header', 'modelsettingsheader', get_string('settings', 'aiprovider_openai')); - $mform->addElement('html', get_string('settings_help', 'aiprovider_openai')); + $settingshelp = \html_writer::tag('p', get_string('settings_help', 'aiprovider_openai')); + $mform->addElement('html', $settingshelp); $mform->addElement( 'textarea', 'modelextraparams', @@ -96,7 +97,8 @@ class hook_listener { if ($targetmodel) { if ($targetmodel->has_model_settings()) { $mform->addElement('header', 'modelsettingsheader', get_string('settings', 'aiprovider_openai')); - $mform->addElement('html', get_string('settings_help', 'aiprovider_openai')); + $settingshelp = \html_writer::tag('p', get_string('settings_help', 'aiprovider_openai')); + $mform->addElement('html', $settingshelp); $targetmodel->add_model_settings($mform); } } From 1ac70050e7e6fe3479524457fcd06a102da39cdd Mon Sep 17 00:00:00 2001 From: David Woloszyn Date: Tue, 13 May 2025 13:46:01 +1000 Subject: [PATCH 2/2] MDL-84751 aiprovider_ollama: Fix settings help spacing --- ai/provider/ollama/classes/hook_listener.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/ai/provider/ollama/classes/hook_listener.php b/ai/provider/ollama/classes/hook_listener.php index ec9b7e313ec..b667d9bc618 100644 --- a/ai/provider/ollama/classes/hook_listener.php +++ b/ai/provider/ollama/classes/hook_listener.php @@ -103,7 +103,8 @@ class hook_listener { if ($model == 'custom') { $mform->addElement('header', 'modelsettingsheader', get_string('settings', 'aiprovider_ollama')); - $mform->addElement('html', get_string('settings_help', 'aiprovider_ollama')); + $settingshelp = \html_writer::tag('p', get_string('settings_help', 'aiprovider_ollama')); + $mform->addElement('html', $settingshelp); $mform->addElement( 'textarea', 'modelextraparams', @@ -117,7 +118,8 @@ class hook_listener { if ($targetmodel) { if ($targetmodel->has_model_settings()) { $mform->addElement('header', 'modelsettingsheader', get_string('settings', 'aiprovider_ollama')); - $mform->addElement('html', get_string('settings_help', 'aiprovider_ollama')); + $settingshelp = \html_writer::tag('p', get_string('settings_help', 'aiprovider_ollama')); + $mform->addElement('html', $settingshelp); $targetmodel->add_model_settings($mform); } }