L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-81114 question: fix selection of random questions with draft status

Browse Source 
We need to pick the latest 'ready' version of each question
(not questions where the latest version is ready).
This commit is contained in:
Tim Hunt
2024-03-08 19:31:43 +00:00
parent 58e84e19b2
commit 7884d5b779
2 changed files with 43 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
question/tests/random_question_loader_test.php
+40 -2
View File
@@ -16,6 +16,9 @@
namespace core_question;
use core_question\local\bank\question_version_status;
use core_question\local\bank\random_question_loader;
use core_question_generator;
use qubaid_list;
use question_bank;
use question_engine;
@@ -24,8 +27,9 @@ use question_engine;
* Tests for the {@see core_question\local\bank\random_question_loader} class.
*
* @package core_question
* @copyright 2015 The Open University
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
* @copyright 2015 The Open University
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
* @covers \core_question\local\bank\random_question_loader
*/
class random_question_loader_test extends \advanced_testcase {
@@ -97,6 +101,40 @@ class random_question_loader_test extends \advanced_testcase {
$this->assertNull($loader->get_next_question_id($cat->id, 0));
}
public function test_draft_questions_not_returned(): void {
$this->resetAfterTest();
$this->setAdminUser();
/** @var core_question_generator $questiongenerator */
$questiongenerator = $this->getDataGenerator()->get_plugin_generator('core_question');
// Create a question in draft state.
$category = $questiongenerator->create_question_category();
$questiongenerator->create_question('shortanswer', null,
['category' => $category->id, 'status' => question_version_status::QUESTION_STATUS_DRAFT]);
// Try to a random question from that category - should not be one.
$loader = new random_question_loader(new qubaid_list([]));
$this->assertNull($loader->get_next_question_id($category->id, false));
}
public function test_questions_with_later_draft_version_is_returned(): void {
$this->resetAfterTest();
$this->setAdminUser();
/** @var core_question_generator $questiongenerator */
$questiongenerator = $this->getDataGenerator()->get_plugin_generator('core_question');
// Create a question in draft state.
$category = $questiongenerator->create_question_category();
$question = $questiongenerator->create_question('shortanswer', null,
['questiontext' => 'V1', 'category' => $category->id]);
$questiongenerator->update_question($question, null,
['questiontext' => 'V2', 'status' => question_version_status::QUESTION_STATUS_DRAFT]);
// Try to a random question from that category - should get V1.
$loader = new random_question_loader(new qubaid_list([]));
$this->assertEquals($question->id, $loader->get_next_question_id($category->id, false));
}
public function test_one_question_category_returns_that_q_then_null() {
$this->resetAfterTest();
$generator = $this->getDataGenerator()->get_plugin_generator('core_question');