From 770cfadd683b558deb71937518f98948a4bd1506 Mon Sep 17 00:00:00 2001 From: Sara Arjona Date: Thu, 27 Feb 2020 13:12:52 +0100 Subject: [PATCH] MDL-67062 core_h5p: fix oracle distinct error --- h5p/classes/api.php | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/h5p/classes/api.php b/h5p/classes/api.php index c1087d17c79..fdd5b29328d 100644 --- a/h5p/classes/api.php +++ b/h5p/classes/api.php @@ -82,10 +82,12 @@ class api { public static function get_dependent_libraries(int $libraryid): array { global $DB; - $sql = 'SELECT DISTINCT hl.* - FROM {h5p_library_dependencies} hld - JOIN {h5p_libraries} hl ON hl.id = hld.libraryid - WHERE hld.requiredlibraryid = :libraryid'; + $sql = 'SELECT * + FROM {h5p_libraries} + WHERE id IN (SELECT DISTINCT hl.id + FROM {h5p_library_dependencies} hld + JOIN {h5p_libraries} hl ON hl.id = hld.libraryid + WHERE hld.requiredlibraryid = :libraryid)'; $params = ['libraryid' => $libraryid]; return $DB->get_records_sql($sql, $params);