L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-55944 testing: Reduce sleep usage.

Browse Source 
Remove sleep() and replace with waiting for a second to roll over,
this results in a simpler call the guarantee time() has moved forward
This commit is contained in:
Russell Smith
2016-09-14 09:49:30 +10:00
parent 0344082208
commit 74ee9d29d2
7 changed files with 23 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/tests/progress_display_test.php
+3 -3
View File
@@ -36,7 +36,7 @@ class progress_display_test extends \advanced_testcase {
$this->assertEquals(1, $progress->get_direction());
$this->assertTimeCurrent($progress->get_last_wibble());
// Wait 1 second to ensure that all code in update_progress is run.
sleep(1);
$this->waitForSecond();
$progress->update_progress();
$this->assertEquals(2, $progress->get_current_state());
$this->assertEquals(1, $progress->get_direction());
@@ -58,14 +58,14 @@ class progress_display_test extends \advanced_testcase {
// Set wibbler to final state and progress to check that it reverses direction.
$progress->set_current_state(core_mock_progress_display::WIBBLE_STATES);
sleep(1);
$this->waitForSecond();
$progress->update_progress();
$this->assertEquals(core_mock_progress_display::WIBBLE_STATES - 1, $progress->get_current_state());
$this->assertEquals(-1, $progress->get_direction());
// Set wibbler to beginning and progress to check that it reverses direction.
$progress->set_current_state(0);
sleep(1);
$this->waitForSecond();
$progress->update_progress();
$this->assertEquals(1, $progress->get_current_state());
$this->assertEquals(1, $progress->get_direction());