From 7466712fc27df8a20023100cab3bc95b19916619 Mon Sep 17 00:00:00 2001
From: Meirza <meirza.arson@moodle.com>
Date: Wed, 8 Feb 2023 15:13:39 +0700
Subject: [PATCH] MDL-77347 mod_feedback: Added missing class properties.

In PHP 8.2 and later, setting a value to an undeclared class property is
deprecated and emits a deprecation notice.
So we need to add missing class properties that still need to be declared.
---
 mod/feedback/classes/responses_table.php                     | 3 +++
 mod/feedback/item/feedback_item_form_class.php               | 4 ++++
 mod/feedback/item/info/info_form.php                         | 3 +++
 mod/feedback/item/multichoicerated/multichoicerated_form.php | 3 +++
 4 files changed, 13 insertions(+)

diff --git a/mod/feedback/classes/responses_table.php b/mod/feedback/classes/responses_table.php
index 58a9c241127..9b02e760139 100644
--- a/mod/feedback/classes/responses_table.php
+++ b/mod/feedback/classes/responses_table.php
@@ -78,6 +78,9 @@ class mod_feedback_responses_table extends table_sql {
     /** @var array the data structure containing the table data for the external function */
     protected $dataforexternal = [];
 
+    /** @var bool true if elements per page > 0, otherwise false. */
+    protected $pageable;
+
     /**
      * Constructor
      *
diff --git a/mod/feedback/item/feedback_item_form_class.php b/mod/feedback/item/feedback_item_form_class.php
index 7fb6379202e..10a25096860 100644
--- a/mod/feedback/item/feedback_item_form_class.php
+++ b/mod/feedback/item/feedback_item_form_class.php
@@ -19,6 +19,10 @@ require_once($CFG->libdir.'/formslib.php');
 define('FEEDBACK_ITEM_NAME_TEXTBOX_SIZE', 80);
 define('FEEDBACK_ITEM_LABEL_TEXTBOX_SIZE', 20);
 abstract class feedback_item_form extends moodleform {
+
+    /** @var string type value in the hidden element. */
+    protected $type;
+
     public function definition() {
         $item = $this->_customdata['item']; //the item object
 
diff --git a/mod/feedback/item/info/info_form.php b/mod/feedback/item/info/info_form.php
index 52b9c5dd7e9..82c8e73a8b8 100644
--- a/mod/feedback/item/info/info_form.php
+++ b/mod/feedback/item/info/info_form.php
@@ -19,6 +19,9 @@ require_once($CFG->dirroot.'/mod/feedback/item/feedback_item_form_class.php');
 class feedback_info_form extends feedback_item_form {
     protected $type = "info";
 
+    /** @var object Form element. */
+    protected $infotype;
+
     public function definition() {
 
         $item = $this->_customdata['item'];
diff --git a/mod/feedback/item/multichoicerated/multichoicerated_form.php b/mod/feedback/item/multichoicerated/multichoicerated_form.php
index 0dcd0f218d2..4d113b3662c 100644
--- a/mod/feedback/item/multichoicerated/multichoicerated_form.php
+++ b/mod/feedback/item/multichoicerated/multichoicerated_form.php
@@ -19,6 +19,9 @@ require_once($CFG->dirroot.'/mod/feedback/item/feedback_item_form_class.php');
 class feedback_multichoicerated_form extends feedback_item_form {
     protected $type = "multichoicerated";
 
+    /** @var object Form element */
+    protected $values;
+
     public function definition() {
         $item = $this->_customdata['item'];
         $common = $this->_customdata['common'];