From 82cca1ab16538c0a31268a873a2fbef81b73a572 Mon Sep 17 00:00:00 2001 From: GeekSmith Date: Fri, 12 Jun 2015 16:21:50 -0400 Subject: [PATCH] MDL-50583 upgrade: Optimize upgrade_minmaxgrade Reverse join order to use existing database keys. Changed query to use the more easily read NOT IN. --- lib/upgradelib.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/upgradelib.php b/lib/upgradelib.php index 68978e296f6..0c2349beb94 100644 --- a/lib/upgradelib.php +++ b/lib/upgradelib.php @@ -2303,10 +2303,10 @@ function upgrade_minmaxgrade() { // Identify the courses that have inconsistencies grade_item vs grade_grade. $sql = "SELECT DISTINCT(gi.courseid) - FROM {grade_items} gi - JOIN {grade_grades} gg + FROM {grade_grades} gg + JOIN {grade_items} gi ON gg.itemid = gi.id - WHERE (gi.itemtype != ? AND gi.itemtype != ?) + WHERE gi.itemtype NOT IN (?, ?) AND (gg.rawgrademax != gi.grademax OR gg.rawgrademin != gi.grademin)"; $rs = $DB->get_recordset_sql($sql, array('course', 'category'));