From 732793f1a5992015451669ca80fd6db5e9d4f50e Mon Sep 17 00:00:00 2001 From: Tim Hunt Date: Thu, 15 Dec 2011 12:22:00 +0000 Subject: [PATCH] MDL-30739 qtype numerical: upgrade script uses SQL that is not cross-DB. --- question/type/numerical/db/upgrade.php | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/question/type/numerical/db/upgrade.php b/question/type/numerical/db/upgrade.php index 5a3ae490c9c..91224cad484 100644 --- a/question/type/numerical/db/upgrade.php +++ b/question/type/numerical/db/upgrade.php @@ -70,12 +70,14 @@ function xmldb_qtype_numerical_upgrade($oldversion) { // Set a better default for questions without units. $DB->execute(' - UPDATE {question_numerical_options} qno + UPDATE {question_numerical_options} SET showunits = 3 WHERE NOT EXISTS ( - SELECT 1 - FROM {question_numerical_units} qnu - WHERE qnu.question = qno.question)'); + SELECT 1 + FROM {question_numerical_units} + WHERE {question_numerical_units}.question = + {question_numerical_options}.question + )'); upgrade_plugin_savepoint(true, 2009100100, 'qtype', 'numerical'); }