From 0960f2f417b4e95fe9ae46bad103c114c57dc9cc Mon Sep 17 00:00:00 2001 From: Adam Olley Date: Tue, 29 Mar 2011 11:46:17 +1030 Subject: [PATCH] MDL-27009: Fix role group by statement for statistics --- lib/statslib.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/statslib.php b/lib/statslib.php index 8a499176ffd..a326c6e3fd1 100644 --- a/lib/statslib.php +++ b/lib/statslib.php @@ -1333,7 +1333,7 @@ function stats_get_report_options($courseid,$mode) { case STATS_MODE_GENERAL: $reportoptions[STATS_REPORT_ACTIVITY] = get_string('statsreport'.STATS_REPORT_ACTIVITY); if ($courseid != SITEID && $context = get_context_instance(CONTEXT_COURSE, $courseid)) { - $sql = 'SELECT r.id, r.name FROM {role} r JOIN {stats_daily} s ON s.roleid = r.id WHERE s.courseid = :courseid GROUP BY s.roleid'; + $sql = 'SELECT r.id, r.name FROM {role} r JOIN {stats_daily} s ON s.roleid = r.id WHERE s.courseid = :courseid GROUP BY r.id, r.name'; if ($roles = $DB->get_records_sql($sql, array('courseid' => $courseid))) { foreach ($roles as $role) { $reportoptions[STATS_REPORT_ACTIVITYBYROLE.$role->id] = get_string('statsreport'.STATS_REPORT_ACTIVITYBYROLE). ' '.$role->name;