From 71b2e366cd9365b3207196b7070419a6954cca15 Mon Sep 17 00:00:00 2001 From: Paul Holden Date: Thu, 8 Feb 2024 13:21:44 +0000 Subject: [PATCH] MDL-80869 mod_bigbluebuttonbn: ensure test retrieves expected record. --- mod/bigbluebuttonbn/tests/instance_test.php | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/mod/bigbluebuttonbn/tests/instance_test.php b/mod/bigbluebuttonbn/tests/instance_test.php index fd2f7bbeabe..194b3c9aac3 100644 --- a/mod/bigbluebuttonbn/tests/instance_test.php +++ b/mod/bigbluebuttonbn/tests/instance_test.php @@ -174,13 +174,15 @@ class instance_test extends advanced_testcase { $instance = instance::get_from_cmid($cm->id); $instance->set_group_id(1); logger::log_meeting_joined_event($instance, 1); - $logs = $DB->get_records('bigbluebuttonbn_logs', - ['courseid' => $course->id, 'bigbluebuttonbnid' => $instance->get_instance_id()], 'timecreated DESC'); - $log = end($logs); - $retrievedinstance = instance::get_from_meetingid( - $log->meetingid - ); + // Get the meeting ID from the logged "join" event. + $meetingid = $DB->get_field('bigbluebuttonbn_logs', 'meetingid', [ + 'courseid' => $course->id, + 'bigbluebuttonbnid' => $instance->get_instance_id(), + 'log' => 'Join', + ], MUST_EXIST); + + $retrievedinstance = instance::get_from_meetingid($meetingid); $this->assertEquals($cm->instance, $retrievedinstance->get_instance_id()); $this->assertEquals($cm->id, $retrievedinstance->get_cm_id()); }