From 70f25ccee41202cfe972209ebab71561ec9ccf4e Mon Sep 17 00:00:00 2001
From: Aaron Barnes <aaronb@catalyst.net.nz>
Date: Thu, 26 Aug 2010 23:05:43 +0000
Subject: [PATCH] course completion: MDL-2631 Only update passing grade if
 grade criteria enabled

---
 course/completion.php | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/course/completion.php b/course/completion.php
index 861a576048b..354c6a11ba7 100644
--- a/course/completion.php
+++ b/course/completion.php
@@ -143,11 +143,13 @@ if ($form->is_cancelled()){
     $aggregation->insert();
 
     // Update course total passing grade
-    if ($grade_item = grade_category::fetch_course_category($course->id)->grade_item) {
-        $grade_item->gradepass = $data->criteria_grade_value;
-        if (method_exists($grade_item, 'update')) {
-            $grade_item->update('course/completion.php');
-        }
+    if (!empty($data->criteria_grade)) {
+    	if ($grade_item = grade_category::fetch_course_category($course->id)->grade_item) {
+        	$grade_item->gradepass = $data->criteria_grade_value;
+        	if (method_exists($grade_item, 'update')) {
+            	$grade_item->update('course/completion.php');
+        	}
+    	}
     }
 
     redirect($CFG->wwwroot."/course/view.php?id=$course->id", get_string('changessaved'));