From 70e3dc44ef403f6d1c4acee19791bf995e81da8a Mon Sep 17 00:00:00 2001
From: Ruslan Kabalin <ruslan.kabalin@gmail.com>
Date: Tue, 1 Feb 2022 09:34:00 +0000
Subject: [PATCH] MDL-79003 eslint: Use 'plugin:promise/recommended'

This commit is a backport of MDL-74301 which should have been backported
at the time.

This enables recommended rules and brings back related rules. Without
reducing level to warn for some of them, this gives numerous (about 88) issues mainly
catch-or-return. Recommended set is defined in
node_modules/eslint-plugin-promise/index.js
---
 .eslintrc | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/.eslintrc b/.eslintrc
index b39c110b1be..9b0339637de 100644
--- a/.eslintrc
+++ b/.eslintrc
@@ -5,7 +5,8 @@
     'jsdoc'
   ],
   'extends': [
-    'eslint:recommended'
+    'eslint:recommended',
+    'plugin:promise/recommended'
   ],
   'env': {
     'browser': true,
@@ -184,14 +185,12 @@
     'unicode-bom': 'error',
     'wrap-regex': 'off',
 
-    // === Promises ===
+    // === Promises (override plugin:promise/recommended) ===
     'promise/always-return': 'warn',
     'promise/no-return-wrap': 'warn',
     'promise/param-names': 'warn',
     'promise/catch-or-return': ['warn', {terminationMethod: ['catch', 'fail']}],
     'promise/no-native': 'warn',
-    'promise/no-promise-in-callback': 'warn',
-    'promise/no-callback-in-promise': 'warn',
     'promise/avoid-new': 'warn',
 
     // === Deprecations ===