L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-70070 phpunit: correct data provider method names.

Browse Source 
They should not be prefixed `test_` because that's how actual
test methods containing assertions are identified by PHPUnit.
This commit is contained in:
Paul Holden
2023-01-16 08:28:31 +00:00
parent 4b69c11978
commit 70a5e38b2c
26 changed files with 120 additions and 179 deletions
Download Patch File Download Diff File Expand all files Collapse all files
message/tests/api_test.php
+3 -3
View File
@@ -5608,7 +5608,7 @@ class api_test extends messagelib_test {
/**
* Data provider for test_get_conversation_counts().
*/
public function test_get_conversation_counts_test_cases() {
public function get_conversation_counts_test_cases() {
$typeindividual = api::MESSAGE_CONVERSATION_TYPE_INDIVIDUAL;
$typegroup = api::MESSAGE_CONVERSATION_TYPE_GROUP;
$typeself = api::MESSAGE_CONVERSATION_TYPE_SELF;
@@ -5971,7 +5971,7 @@ class api_test extends messagelib_test {
/**
* Test the get_conversation_counts() function.
*
* @dataProvider test_get_conversation_counts_test_cases()
* @dataProvider get_conversation_counts_test_cases
* @param array $conversationconfigs Conversations to create
* @param int $deletemessagesuser The user who is deleting the messages
* @param array $deletemessages The list of messages to delete (by index)
@@ -6094,7 +6094,7 @@ class api_test extends messagelib_test {
/**
* Test the get_unread_conversation_counts() function.
*
* @dataProvider test_get_conversation_counts_test_cases()
* @dataProvider get_conversation_counts_test_cases
* @param array $conversationconfigs Conversations to create
* @param int $deletemessagesuser The user who is deleting the messages
* @param array $deletemessages The list of messages to delete (by index)