diff --git a/blocks/rss_client/viewfeed.php b/blocks/rss_client/viewfeed.php index 1c287d703c5..26451d6b742 100644 --- a/blocks/rss_client/viewfeed.php +++ b/blocks/rss_client/viewfeed.php @@ -84,15 +84,16 @@ if (!empty($rssrecord->preferredtitle)) { $feedtitle = $rss->get_title(); } echo ''."\n"; -echo ''."\n"; +echo ''."\n"; foreach ($rss->get_items() as $item) { echo ''."\n"; echo ''."\n"; echo ''."\n"; + echo format_text($item->get_description(), FORMAT_HTML) .''."\n"; } echo '
'. $feedtitle .'
'. s($feedtitle) .'
'."\n"; - echo ''. $item->get_title(); + echo ''; + echo s($item->get_title()); echo ''."\n"; echo '
'; - echo $item->get_description() .'
'."\n"; diff --git a/blog/renderer.php b/blog/renderer.php index b605016d10e..af1724de1ab 100644 --- a/blog/renderer.php +++ b/blog/renderer.php @@ -119,11 +119,14 @@ class core_blog_renderer extends plugin_renderer_base { // Body. $o .= format_text($entry->summary, $entry->summaryformat, array('overflowdiv' => true)); - // Uniquehash is used as a link to an external blog. if (!empty($entry->uniquehash)) { - $o .= $this->output->container_start('externalblog'); - $o .= html_writer::link($entry->uniquehash, get_string('linktooriginalentry', 'blog')); - $o .= $this->output->container_end(); + // Uniquehash is used as a link to an external blog. + $url = clean_param($entry->uniquehash, PARAM_URL); + if (!empty($url)) { + $o .= $this->output->container_start('externalblog'); + $o .= html_writer::link($url, get_string('linktooriginalentry', 'blog')); + $o .= $this->output->container_end(); + } } // Links to tags. diff --git a/lib/simplepie/readme_moodle.txt b/lib/simplepie/readme_moodle.txt index 28bfa762799..578068837fc 100644 --- a/lib/simplepie/readme_moodle.txt +++ b/lib/simplepie/readme_moodle.txt @@ -5,6 +5,8 @@ Obtained from http://github.com/simplepie/simplepie/commit/798f4674468316b8cc70f Changes: * None. This import contains _NO_CHANGES_ to the simplepie.inc file, changes are controlled through OO extension of the classes instead. + * Exception: The Sanitizer has been modified to return valid URLs. The change + is done through OO extension in 25 and upwards but not in 23 and 24. Dan Poltawski Petr Skoda diff --git a/lib/simplepie/simplepie.class.php b/lib/simplepie/simplepie.class.php index 2aeb1ff569e..161cdc7143b 100644 --- a/lib/simplepie/simplepie.class.php +++ b/lib/simplepie/simplepie.class.php @@ -14466,6 +14466,10 @@ class SimplePie_Sanitize if ($type & SIMPLEPIE_CONSTRUCT_IRI) { $data = SimplePie_Misc::absolutize_url($data, $base); + // Moodle modification - Only return valid URLs. Note this change is interim and + // 2.5 and upwards have the cleaning performed in our own sanitizer. + $data = clean_param($data, PARAM_URL); + // End of Moodle modification. } if ($type & (SIMPLEPIE_CONSTRUCT_TEXT | SIMPLEPIE_CONSTRUCT_IRI)) diff --git a/version.php b/version.php index 31ce846d4ee..72d930a39f1 100644 --- a/version.php +++ b/version.php @@ -29,11 +29,11 @@ defined('MOODLE_INTERNAL') || die(); -$version = 2012120305.13; // 20121203 = branching date YYYYMMDD - do not modify! +$version = 2012120306.00; // 20121203 = branching date YYYYMMDD - do not modify! // RR = release increments - 00 in DEV branches // .XX = incremental changes -$release = '2.4.5+ (Build: 20130905)'; // Human-friendly version name +$release = '2.4.6 (Build: 20130909)'; // Human-friendly version name $branch = '24'; // this version's branch $maturity = MATURITY_STABLE; // this version's maturity level