From 6b356ae385e7e9dfd8c8c185b5c0ae44fea16912 Mon Sep 17 00:00:00 2001
From: Jonathan Harker <jonathan@catalyst.net.nz>
Date: Tue, 23 Sep 2014 12:52:47 +1200
Subject: [PATCH] MDL-47316 mod_forum: Fix course overview performance
 regression

 make more efficient use of mod_info cache by processing courses
 sequentially.

Change-Id: I03b808c8a7efc42879ec2689fbd2a9fe7a8f1103
---
 mod/forum/lib.php | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/mod/forum/lib.php b/mod/forum/lib.php
index 9b051a91bda..33e7795cf68 100644
--- a/mod/forum/lib.php
+++ b/mod/forum/lib.php
@@ -1457,7 +1457,8 @@ function forum_print_overview($courses,&$htmlarray) {
                 .'JOIN {forum_posts} p ON p.discussion = d.id '
                 ."WHERE ($coursessql) "
                 .'AND p.userid != ? '
-                .'GROUP BY d.id, d.forum, f.course, d.groupid';
+                .'GROUP BY d.id, d.forum, f.course, d.groupid '
+                .'ORDER BY f.course, d.forum';
 
     // Avoid warnings.
     if (!$discussions = $DB->get_records_sql($sql, $params)) {