diff --git a/mod/forum/report/summary/classes/summary_table.php b/mod/forum/report/summary/classes/summary_table.php index 76153e50a77..ca1dd93d16f 100644 --- a/mod/forum/report/summary/classes/summary_table.php +++ b/mod/forum/report/summary/classes/summary_table.php @@ -687,23 +687,21 @@ class summary_table extends table_sql { * that they have not been calculated yet. * @return bool */ - private function show_word_char_counts(): bool { + protected function show_word_char_counts(): bool { global $DB; - if (!is_null($this->showwordcharcounts)) { - return $this->showwordcharcounts; - } + if (is_null($this->showwordcharcounts)) { + // This should be really fast. + $sql = "SELECT 'x' + FROM {forum_posts} fp + JOIN {forum_discussions} fd ON fd.id = fp.discussion + WHERE fd.forum = :forumid AND (fp.wordcount IS NULL OR fp.charcount IS NULL)"; - // This should be really fast. - $sql = "SELECT 'x' - FROM {forum_posts} fp - JOIN {forum_discussions} fd ON fd.id = fp.discussion - WHERE fd.forum = :forumid AND (fp.wordcount IS NULL OR fp.charcount IS NULL)"; - - if ($DB->record_exists_sql($sql, ['forumid' => $this->cm->instance])) { - $this->showwordcharcounts = false; - } else { - $this->showwordcharcounts = true; + if ($DB->record_exists_sql($sql, ['forumid' => $this->cm->instance])) { + $this->showwordcharcounts = false; + } else { + $this->showwordcharcounts = true; + } } return $this->showwordcharcounts; diff --git a/mod/forum/report/summary/lang/en/forumreport_summary.php b/mod/forum/report/summary/lang/en/forumreport_summary.php index 1288ad9963e..50d10687570 100644 --- a/mod/forum/report/summary/lang/en/forumreport_summary.php +++ b/mod/forum/report/summary/lang/en/forumreport_summary.php @@ -23,7 +23,7 @@ */ $string['attachmentcount'] = 'Number of attachments'; -$string['charcount'] = 'Char count'; +$string['charcount'] = 'Character count'; $string['viewcount'] = 'Number of views'; $string['earliestpost'] = 'Earliest post'; $string['filter:groupsbuttonlabel'] = 'Open the groups filter';