From 659d31bf25ec6f19061bac9dd7fd3fa6aeb9e2d8 Mon Sep 17 00:00:00 2001 From: Marina Glancy Date: Thu, 14 Jul 2011 11:00:09 +0800 Subject: [PATCH] MDL-27756 Improving move_course() performance --- course/lib.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/course/lib.php b/course/lib.php index 6aa7df9ddb5..968d68f47c8 100644 --- a/course/lib.php +++ b/course/lib.php @@ -3370,10 +3370,13 @@ function move_courses($courseids, $categoryid) { } $courseids = array_reverse($courseids); + $newparent = get_context_instance(CONTEXT_COURSECAT, $category->id); $i = 1; foreach ($courseids as $courseid) { if ($course = $DB->get_record('course', array('id'=>$courseid), 'id, category')) { + $course = new stdClass(); + $course->id = $courseid; $course->category = $category->id; $course->sortorder = $category->sortorder + MAX_COURSES_IN_CATEGORY - $i++; if ($category->visible == 0) { @@ -3385,7 +3388,6 @@ function move_courses($courseids, $categoryid) { $DB->update_record('course', $course); $context = get_context_instance(CONTEXT_COURSE, $course->id); - $newparent = get_context_instance(CONTEXT_COURSECAT, $course->category); context_moved($context, $newparent); } }