From 64ced100cccfce633b5dfcde40f9aa66a6887f87 Mon Sep 17 00:00:00 2001 From: Dan Marsden Date: Fri, 11 Jul 2014 13:24:05 +1200 Subject: [PATCH] MDL-31366 Feedback: decode htmlchars on output to excel --- mod/feedback/item/textarea/lib.php | 4 ++-- mod/feedback/item/textfield/lib.php | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/mod/feedback/item/textarea/lib.php b/mod/feedback/item/textarea/lib.php index 304e5d7cfb3..e086e1259a7 100644 --- a/mod/feedback/item/textarea/lib.php +++ b/mod/feedback/item/textarea/lib.php @@ -177,12 +177,12 @@ class feedback_item_textarea extends feedback_item_base { $data = $analysed_item->data; if (is_array($data)) { if (isset($data[0])) { - $worksheet->write_string($row_offset, 2, $data[0], $xls_formats->value_bold); + $worksheet->write_string($row_offset, 2, htmlspecialchars_decode($data[0], ENT_QUOTES), $xls_formats->value_bold); } $row_offset++; $sizeofdata = count($data); for ($i = 1; $i < $sizeofdata; $i++) { - $worksheet->write_string($row_offset, 2, $data[$i], $xls_formats->default); + $worksheet->write_string($row_offset, 2, htmlspecialchars_decode($data[$i], ENT_QUOTES), $xls_formats->default); $row_offset++; } } diff --git a/mod/feedback/item/textfield/lib.php b/mod/feedback/item/textfield/lib.php index ccbf806379d..77027c142e2 100644 --- a/mod/feedback/item/textfield/lib.php +++ b/mod/feedback/item/textfield/lib.php @@ -167,11 +167,11 @@ class feedback_item_textfield extends feedback_item_base { $worksheet->write_string($row_offset, 1, $item->name, $xls_formats->head2); $data = $analysed_item->data; if (is_array($data)) { - $worksheet->write_string($row_offset, 2, $data[0], $xls_formats->value_bold); + $worksheet->write_string($row_offset, 2, htmlspecialchars_decode($data[0], ENT_QUOTES), $xls_formats->value_bold); $row_offset++; $sizeofdata = count($data); for ($i = 1; $i < $sizeofdata; $i++) { - $worksheet->write_string($row_offset, 2, $data[$i], $xls_formats->default); + $worksheet->write_string($row_offset, 2, htmlspecialchars_decode($data[$i], ENT_QUOTES), $xls_formats->default); $row_offset++; } }