From 509c029923b9d7a871ea232ffa09786466f8e758 Mon Sep 17 00:00:00 2001
From: Paul Holden <paulh@moodle.com>
Date: Tue, 7 Jan 2025 15:04:41 +0000
Subject: [PATCH] MDL-84085 mod_h5pactivity: account for missing `ra` table
 join alias.

---
 mod/h5pactivity/classes/local/manager.php | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/mod/h5pactivity/classes/local/manager.php b/mod/h5pactivity/classes/local/manager.php
index 579f3352c7c..3a7c6b088a4 100644
--- a/mod/h5pactivity/classes/local/manager.php
+++ b/mod/h5pactivity/classes/local/manager.php
@@ -357,7 +357,6 @@ class manager {
 
         // We want to present all potential users.
         $capjoin = get_enrolled_with_capabilities_join($context, '', 'mod/h5pactivity:view', $currentgroup);
-
         if ($capjoin->cannotmatchanyrows) {
             return $capjoin;
         }
@@ -368,11 +367,13 @@ class manager {
             return $capjoin;
         }
 
-        $capjoin = new sql_join(
-            $capjoin->joins . "\n LEFT " . str_replace('ra', 'reviewer', $reviewersjoin->joins),
-            $capjoin->wheres . " AND reviewer.userid IS NULL",
-            $capjoin->params
-        );
+        if (str_contains($reviewersjoin->joins, 'ra')) {
+            $capjoin = new sql_join(
+                $capjoin->joins . "\n LEFT " . str_replace('ra', 'reviewer', $reviewersjoin->joins),
+                $capjoin->wheres . " AND reviewer.userid IS NULL",
+                $capjoin->params
+            );
+        }
 
         if ($allpotentialusers) {
             return $capjoin;