From 6403c8d39b07dafb277679910ea8e7b914112739 Mon Sep 17 00:00:00 2001 From: Tim Hunt Date: Mon, 12 Jan 2015 13:18:49 +0000 Subject: [PATCH] MDL-48477 questions: no delete icon for only top-level category The back end code already threw an exception if you clicked the icon, so you could not delete the category, but we should not have shown the icon in the first place. Thanks to Pramith Dayananda for working out the fix for this issue. I am just committing it. --- question/category_class.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/question/category_class.php b/question/category_class.php index 4684415fd73..b5d63322a04 100644 --- a/question/category_class.php +++ b/question/category_class.php @@ -113,7 +113,7 @@ class question_category_list_item extends list_item { array('context' => $this->parentlist->context, 'noclean' => true)); // don't allow delete if this is the last category in this context. - if (count($this->parentlist->records) != 1) { + if (!question_is_only_toplevel_category_in_context($category->id)) { $deleteurl = new moodle_url($this->parentlist->pageurl, array('delete' => $this->id, 'sesskey' => sesskey())); $item .= html_writer::link($deleteurl, html_writer::empty_tag('img', array('src' => $OUTPUT->pix_url('t/delete'),