diff --git a/lib/db/upgrade.php b/lib/db/upgrade.php index 437233839c1..2edf3111bdb 100644 --- a/lib/db/upgrade.php +++ b/lib/db/upgrade.php @@ -2543,21 +2543,6 @@ function xmldb_main_upgrade($oldversion) { } if ($oldversion < 2021052500.01) { - - // Define field timecreated to be added to task_adhoc. - $table = new xmldb_table('task_adhoc'); - $field = new xmldb_field('timecreated', XMLDB_TYPE_INTEGER, '10', null, XMLDB_NOTNULL, null, '0', 'blocking'); - - // Conditionally launch add field timecreated. - if (!$dbman->field_exists($table, $field)) { - $dbman->add_field($table, $field); - } - - // Main savepoint reached. - upgrade_main_savepoint(true, 2021052500.01); - } - - if ($oldversion < 2021052500.02) { // Delete all user evidence files from users that have been deleted. $sql = "SELECT DISTINCT f.* FROM {files} f @@ -2572,6 +2557,21 @@ function xmldb_main_upgrade($oldversion) { $fs->get_file_instance($stalefile)->delete(); } + upgrade_main_savepoint(true, 2021052500.01); + } + + if ($oldversion < 2021052500.02) { + + // Define field timecreated to be added to task_adhoc. + $table = new xmldb_table('task_adhoc'); + $field = new xmldb_field('timecreated', XMLDB_TYPE_INTEGER, '10', null, XMLDB_NOTNULL, null, '0', 'blocking'); + + // Conditionally launch add field timecreated. + if (!$dbman->field_exists($table, $field)) { + $dbman->add_field($table, $field); + } + + // Main savepoint reached. upgrade_main_savepoint(true, 2021052500.02); } diff --git a/lib/phpunit/classes/phpunit_dataset.php b/lib/phpunit/classes/phpunit_dataset.php index 28a4b3bc062..fbb8a3cd9f4 100644 --- a/lib/phpunit/classes/phpunit_dataset.php +++ b/lib/phpunit/classes/phpunit_dataset.php @@ -98,7 +98,7 @@ class phpunit_dataset { * * @param string $content contents (CSV or XML) to load. * @param string $type format of the content to be loaded (csv or xml). - * @param string $table|null name of the table which the file belongs to (only for CSV files). + * @param string|null $table name of the table which the file belongs to (only for CSV files). */ public function from_string(string $content, string $type, ?string $table = null): void { switch ($type) {