From 617a32f3f0cc5fc3d2b5ec77653e75f3a8b0ca63 Mon Sep 17 00:00:00 2001 From: Matthew Hilton Date: Thu, 6 Oct 2022 13:12:13 +1000 Subject: [PATCH] MDL-74911 assignfeedback_editpdf: unlock session when polling conversion Polling conversions will run the document conversion immediately if the conversion has not already been completed. Releasing the session lock while doing this ensures large conversions do not unnecessarily hold the users session. --- mod/assign/feedback/editpdf/ajax.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/mod/assign/feedback/editpdf/ajax.php b/mod/assign/feedback/editpdf/ajax.php index 624033302f3..a9960c6096f 100644 --- a/mod/assign/feedback/editpdf/ajax.php +++ b/mod/assign/feedback/editpdf/ajax.php @@ -52,6 +52,9 @@ if (!$assignment->can_view_submission($userid)) { } if ($action === 'pollconversions') { + // Poll conversions does not require session lock. + \core\session\manager::write_close(); + $draft = true; if (!has_capability('mod/assign:grade', $context)) { // A student always sees the readonly version.