From 2f2cae97adb4ecdb6a2247d791092006861c9097 Mon Sep 17 00:00:00 2001 From: Damyon Wiese Date: Sun, 25 Aug 2013 22:16:34 +0800 Subject: [PATCH] MDL-41149 assign: Group submission updates emailed to wrong person grade_item_update was altering the userid in the submission record instead of cloning it. This meant only the last member of a group recieved all notifications meant for other students in the group. --- mod/assign/locallib.php | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/mod/assign/locallib.php b/mod/assign/locallib.php index 9977d6b1bae..e9be1f587b3 100644 --- a/mod/assign/locallib.php +++ b/mod/assign/locallib.php @@ -3660,9 +3660,10 @@ class assign { $team = groups_get_members($submission->groupid, 'u.id'); foreach ($team as $member) { - $submission->groupid = 0; - $submission->userid = $member->id; - $this->gradebook_item_update($submission, null); + $membersubmission = clone $submission; + $membersubmission->groupid = 0; + $membersubmission->userid = $member->id; + $this->gradebook_item_update($membersubmission, null); } return; }