diff --git a/backup/util/ui/renderer.php b/backup/util/ui/renderer.php index b96bad254ea..2f04bceabfd 100644 --- a/backup/util/ui/renderer.php +++ b/backup/util/ui/renderer.php @@ -629,7 +629,7 @@ class core_backup_renderer extends plugin_renderer_base { } $row->cells = array( html_writer::empty_tag('input', array('type'=>'radio', 'name'=>'targetid', 'value'=>$category->id)), - $category->name, + format_string($category->name, true, array('context' => get_context_instance(CONTEXT_COURSECAT, $category->id))), format_text($category->description, $category->descriptionformat, array('overflowdiv'=>true)) ); $table->data[] = $row; diff --git a/blocks/course_list/block_course_list.php b/blocks/course_list/block_course_list.php index 52fc1826149..7ea2ff6a2e1 100644 --- a/blocks/course_list/block_course_list.php +++ b/blocks/course_list/block_course_list.php @@ -56,8 +56,9 @@ class block_course_list extends block_list { if ($categories) { //Check we have categories if (count($categories) > 1 || (count($categories) == 1 && $DB->count_records('course') > 200)) { // Just print top level category links foreach ($categories as $category) { + $categoryname = format_string($category->name, true, array('context' => get_context_instance(CONTEXT_COURSECAT, $category->id))); $linkcss = $category->visible ? "" : " class=\"dimmed\" "; - $this->content->items[]="wwwroot/course/category.php?id=$category->id\">".$icon . format_string($category->name) . ""; + $this->content->items[]="wwwroot/course/category.php?id=$category->id\">".$icon . $categoryname . ""; } /// If we can update any course of the view all isn't hidden, show the view all courses link if (has_capability('moodle/course:update', get_context_instance(CONTEXT_SYSTEM)) || empty($CFG->block_course_list_hideallcourseslink)) { @@ -75,7 +76,7 @@ class block_course_list extends block_list { $this->content->items[]="shortname)."\" ". "href=\"$CFG->wwwroot/course/view.php?id=$course->id\">" - .$icon. format_string($course->fullname) . ""; + .$icon. format_string($course->fullname, true, array('context' => get_context_instance(CONTEXT_COURSE, $course->id))) . ""; } /// If we can update any course of the view all isn't hidden, show the view all courses link if (has_capability('moodle/course:update', get_context_instance(CONTEXT_SYSTEM)) || empty($CFG->block_course_list_hideallcourseslink)) { diff --git a/course/category.php b/course/category.php index 12558aa2372..9ed7ebca867 100644 --- a/course/category.php +++ b/course/category.php @@ -232,7 +232,7 @@ } $catlinkcss = $subcategory->visible ? '' : ' class="dimmed" '; echo ''. - format_string($subcategory->name).'
'; + format_string($subcategory->name, true, array('context' => get_context_instance(CONTEXT_COURSECAT, $subcategory->id))).'
'; } } if (!$firstentry) { diff --git a/course/delete.php b/course/delete.php index c0a60ca8872..a59a4e847f5 100644 --- a/course/delete.php +++ b/course/delete.php @@ -30,10 +30,11 @@ } $category = $DB->get_record("course_categories", array("id"=>$course->category)); + $categoryname = format_string($category->name, true, array('context' => get_context_instance(CONTEXT_COURSECAT, $category->id))); $PAGE->navbar->add($stradministration, new moodle_url('/admin/index.php/')); $PAGE->navbar->add($strcategories, new moodle_url('/course/index.php')); - $PAGE->navbar->add($category->name, new moodle_url('/course/category.php', array('id'=>$course->category))); + $PAGE->navbar->add($categoryname, new moodle_url('/course/category.php', array('id'=>$course->category))); if (! $delete) { $strdeletecheck = get_string("deletecheck", "", $course->shortname); $strdeletecoursecheck = get_string("deletecoursecheck"); diff --git a/course/delete_category_form.php b/course/delete_category_form.php index 7681bffb28e..f2d394cd907 100644 --- a/course/delete_category_form.php +++ b/course/delete_category_form.php @@ -78,11 +78,11 @@ class delete_category_form extends moodleform { } /// Now build the form. - $mform->addElement('header','general', get_string('categorycurrentcontents', '', format_string($category->name))); + $mform->addElement('header','general', get_string('categorycurrentcontents', '', format_string($category->name, true, array('context' => $categorycontext)))); if ($containscourses || $containscategories || $containsquestions) { if (empty($options)) { - print_error('youcannotdeletecategory', 'error', 'index.php', format_string($category->name)); + print_error('youcannotdeletecategory', 'error', 'index.php', format_string($category->name, true, array('context' => $categorycontext))); } /// Describe the contents of this category. diff --git a/course/index.php b/course/index.php index b1998ef8fa6..f0a0c104893 100644 --- a/course/index.php +++ b/course/index.php @@ -125,7 +125,7 @@ if (!empty($delete) and confirm_sesskey()) { require_capability('moodle/category:manage', $context); require_capability('moodle/category:manage', get_category_or_system_context($deletecat->parent)); - $heading = get_string('deletecategory', 'moodle', format_string($deletecat->name)); + $heading = get_string('deletecategory', 'moodle', format_string($deletecat->name, true, array('context' => $context))); require_once('delete_category_form.php'); $mform = new delete_category_form(null, $deletecat); $mform->set_data(array('delete'=>$delete)); @@ -151,7 +151,7 @@ if (!empty($delete) and confirm_sesskey()) { foreach($deletedcourses as $course) { echo $OUTPUT->notification(get_string('coursedeleted', '', $course->shortname), 'notifysuccess'); } - echo $OUTPUT->notification(get_string('coursecategorydeleted', '', format_string($deletecat->name)), 'notifysuccess'); + echo $OUTPUT->notification(get_string('coursecategorydeleted', '', format_string($deletecat->name, true, array('context' => $context))), 'notifysuccess'); } else { category_delete_move($deletecat, $data->newparent, true); @@ -315,7 +315,7 @@ function print_category_edit($category, $displaylist, $parentslist, $depth=-1, $ $linkcss = $category->visible ? '' : ' class="dimmed" '; echo ''. - format_string($category->name).''; + format_string($category->name, true, array('context' => $category->context)).''; echo ''; echo ''.$category->coursecount.''; diff --git a/course/lib.php b/course/lib.php index 35be49b965a..22292e1f153 100644 --- a/course/lib.php +++ b/course/lib.php @@ -1980,11 +1980,14 @@ function make_categories_list(&$list, &$parents, $requiredcapability = '', return; } + $context = get_context_instance(CONTEXT_COURSECAT, $category->id); + $categoryname = format_string($category->name, true, array('context' => $context)); + // Update $path. if ($path) { - $path = $path.' / '.format_string($category->name); + $path = $path.' / '.$categoryname; } else { - $path = format_string($category->name); + $path = $categoryname; } // Add this category to $list, if the permissions check out. @@ -1992,9 +1995,8 @@ function make_categories_list(&$list, &$parents, $requiredcapability = '', $list[$category->id] = $path; } else { - ensure_context_subobj_present($category, CONTEXT_COURSECAT); $requiredcapability = (array)$requiredcapability; - if (has_all_capabilities($requiredcapability, $category->context)) { + if (has_all_capabilities($requiredcapability, $context)) { $list[$category->id] = $path; } } @@ -2167,11 +2169,14 @@ function print_category_info($category, $depth=0, $showcourses = false) { } $courses = get_courses($category->id, 'c.sortorder ASC', 'c.id,c.sortorder,c.visible,c.fullname,c.shortname,c.summary'); + $context = get_context_instance(CONTEXT_COURSECAT, $category->id); + $fullname = format_string($category->name, true, array('context' => $context)); + if ($showcourses and $coursecount) { echo '
'; $cat = ''; $cat .= html_writer::tag('div', $catimage, array('class'=>'image')); - $catlink = html_writer::link(new moodle_url('/course/category.php', array('id'=>$category->id)), format_string($category->name), $catlinkcss); + $catlink = html_writer::link(new moodle_url('/course/category.php', array('id'=>$category->id)), $fullname, $catlinkcss); $cat .= html_writer::tag('div', $catlink, array('class'=>'name')); $html = ''; @@ -2229,7 +2234,7 @@ function print_category_info($category, $depth=0, $showcourses = false) { } else { echo '
'; $html = ''; - $cat = html_writer::link(new moodle_url('/course/category.php', array('id'=>$category->id)), format_string($category->name), $catlinkcss); + $cat = html_writer::link(new moodle_url('/course/category.php', array('id'=>$category->id)), $fullname, $catlinkcss); $cat .= html_writer::tag('span', ' ('.count($courses).')', array('title'=>get_string('numberofcourses'), 'class'=>'numberofcourse')); if ($depth > 0) { diff --git a/course/renderer.php b/course/renderer.php index 07b7bc58618..3e9898cd0c5 100644 --- a/course/renderer.php +++ b/course/renderer.php @@ -107,9 +107,11 @@ class core_course_renderer extends plugin_renderer_base { $classes[] = 'collapsed'; } } + $categoryname = format_string($category->name, true, array('context' => get_context_instance(CONTEXT_COURSECAT, $category->id))); + $content .= html_writer::start_tag('div', array('class'=>join(' ', $classes))); $content .= html_writer::start_tag('div', array('class'=>'category_label')); - $content .= html_writer::link(new moodle_url('/course/category.php', array('id'=>$category->id)), $category->name, array('class'=>'category_link')); + $content .= html_writer::link(new moodle_url('/course/category.php', array('id'=>$category->id)), $categoryname, array('class'=>'category_link')); $content .= html_writer::end_tag('div'); if ($hassubcategories) { $content .= html_writer::start_tag('div', array('class'=>'subcategories')); diff --git a/lib/accesslib.php b/lib/accesslib.php index b5d8014b562..cb947fc3bc3 100644 --- a/lib/accesslib.php +++ b/lib/accesslib.php @@ -3578,7 +3578,7 @@ function print_context_name($context, $withprefix = true, $short = false) { if ($withprefix){ $name = get_string('category').': '; } - $name .=format_string($category->name); + $name .= format_string($category->name, true, array('context' => $context)); } break; diff --git a/lib/navigationlib.php b/lib/navigationlib.php index 0f3a7895150..adb1f980a3d 100644 --- a/lib/navigationlib.php +++ b/lib/navigationlib.php @@ -1510,7 +1510,9 @@ class global_navigation extends navigation_node { continue; } $url = new moodle_url('/course/category.php', array('id' => $category->id)); - $categorynode = $parent->add($category->name, $url, self::TYPE_CATEGORY, $category->name, $category->id); + $context = get_context_instance(CONTEXT_COURSECAT, $category->id); + $categoryname = format_string($category->name, true, array('context' => $context)); + $categorynode = $parent->add($categoryname, $url, self::TYPE_CATEGORY, $categoryname, $category->id); if (empty($category->visible)) { if (has_capability('moodle/category:viewhiddencategories', get_system_context())) { $categorynode->hidden = true; diff --git a/mod/feedback/item/info/lib.php b/mod/feedback/item/info/lib.php index b6311a84eb3..68df363b1db 100644 --- a/mod/feedback/item/info/lib.php +++ b/mod/feedback/item/info/lib.php @@ -187,7 +187,7 @@ class feedback_item_info extends feedback_item_base { $itemshowvalue = $itemvalue; break; case 3: - $itemvalue = $coursecategory->name; + $itemvalue = format_string($coursecategory->name, true, array('context' => get_context_instance(CONTEXT_COURSECAT, $coursecategory->id))); $itemshowvalue = $itemvalue; break; } @@ -243,7 +243,7 @@ class feedback_item_info extends feedback_item_base { $itemshowvalue = $itemvalue; break; case 3: - $itemvalue = $coursecategory->name; + $itemvalue = format_string($coursecategory->name, true, array('context' => get_context_instance(CONTEXT_COURSECAT, $coursecategory->id))); $itemshowvalue = $itemvalue; break; }