L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-75111 phpunit: Move tests to use correct names and ns (take#4)

Browse Source 
Applied the following changes to various testcase classes:

- Namespaced with component[\level2-API]
- Moved to level2-API subdirectory when required.
- Fixed incorrect use statements with leading backslash.
- Remove file phpdoc block
- Remove MOODLE_INTERNAL if not needed.
- Changed code to point to global scope when needed.
- Fix some relative paths and comments here and there.
- All them passing individually.
- Complete runs passing too.

Special mention to:

- The following task tests have been moved within the level2 directory:
  - \core\adhoc_task_test => \core\task\adhoc_task_test
  - \core\scheduled_task_test => \core\task\scheduled_task_test
  - \core\calendar_cron_task_test => \core\task\calendar_cron_task_test
  - \core\h5p_get_content_types_task_test => \core\task\h5p_get_content_types_task_test
  - \core\task_database_logger_test => \core\task\database_logger_test
  - \core\task_logging_test => \core\task\logging_test

- The following event tests have been moved within level2 directory:
  - \core\event_context_locked_test => \core\event\context_locked_test
  - \core\event_deprecated_test => \core\event\deprecated_test
  - \core\event_grade_deleted_test => \core\event\grade_deleted_test
  - \core\event_profile_field_test => \core\event\profile_field_test
  - \core\event_unknown_logged_test => \core\event\unknown_logged_test
  - \core\event_user_graded_test => \core\event\user_graded_test
  - \core\event_user_password_updated_test => \core\event\user_password_updated_test

- The following output tests have been moved within level2 directory:
  - \core\mustache_template_finder_test => \core\output\mustache_template_finder_test
  - \core\mustache_template_source_loader_test => \core\output\mustache_template_source_loader_test
  - \core\output_mustache_helper_collection_test => \core\output\mustache_helper_collection_test

- The following tests have been moved to their correct tests directories:
  - lib/tests/time_splittings_test.php => analytics/tests/time_splittings_test.php

- All the classes and tests under lib/filebrowser and lib/filestorage
  belong to core, not to core_files. Some day we should move
  them to their correct subsystem.
- All the classes and tests under lib/grade belong to core, not
  to core_grades. Some day we should move them to their correct
  subsystem.
- The core_grades_external class and its \core\grades_external_test
  unit test should belong to the grades subsystem or, alternatively,
  to \core\external, they both should be moved together.
- The core_grading_external class and its \core\grading_external_test
  unit test should belong to the grading subsystem or, alternatively,
  to \core\external, they both should be moved together.
- The \core\message\message and \core\message\inbound (may be others)
  classes, and their associated tests should go to the core_message
  subsystem.
- The core_user class, and its associated tests should go to the
  core_user subsystem.
- The \core\update namespace is plain wrong (update is not valid API)
  and needs action 1) create it or 2) move elsewhere.
This commit is contained in:
Eloy Lafuente (stronk7)
2022-08-26 16:34:24 +02:00
parent cd11b40558
commit 5c884e835e
125 changed files with 2430 additions and 2726 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/tests/user_test.php
+124 -130
View File
@@ -14,13 +14,7 @@
// You should have received a copy of the GNU General Public License
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
/**
* Tests core_user class.
*
* @package core
* @copyright 2013 Rajesh Taneja <[email protected]>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
namespace core;
/**
* Test core_user class.
@@ -29,7 +23,7 @@
* @copyright 2013 Rajesh Taneja <[email protected]>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
class core_user_testcase extends advanced_testcase {
class user_test extends \advanced_testcase {
/**
* Setup test data.
@@ -44,45 +38,45 @@ class core_user_testcase extends advanced_testcase {
// Create user and try fetach it with api.
$user = $this->getDataGenerator()->create_user();
$this->assertEquals($user, core_user::get_user($user->id, '*', MUST_EXIST));
$this->assertEquals($user, \core_user::get_user($user->id, '*', MUST_EXIST));
// Test noreply user.
$CFG->noreplyuserid = null;
$noreplyuser = core_user::get_noreply_user();
$noreplyuser = \core_user::get_noreply_user();
$this->assertEquals(1, $noreplyuser->emailstop);
$this->assertFalse(core_user::is_real_user($noreplyuser->id));
$this->assertFalse(\core_user::is_real_user($noreplyuser->id));
$this->assertEquals($CFG->noreplyaddress, $noreplyuser->email);
$this->assertEquals(get_string('noreplyname'), $noreplyuser->firstname);
// Set user as noreply user and make sure noreply propery is set.
core_user::reset_internal_users();
\core_user::reset_internal_users();
$CFG->noreplyuserid = $user->id;
$noreplyuser = core_user::get_noreply_user();
$noreplyuser = \core_user::get_noreply_user();
$this->assertEquals(1, $noreplyuser->emailstop);
$this->assertTrue(core_user::is_real_user($noreplyuser->id));
$this->assertTrue(\core_user::is_real_user($noreplyuser->id));
// Test support user.
core_user::reset_internal_users();
\core_user::reset_internal_users();
$CFG->supportemail = null;
$CFG->noreplyuserid = null;
$supportuser = core_user::get_support_user();
$supportuser = \core_user::get_support_user();
$adminuser = get_admin();
$this->assertEquals($adminuser, $supportuser);
$this->assertTrue(core_user::is_real_user($supportuser->id));
$this->assertTrue(\core_user::is_real_user($supportuser->id));
// When supportemail is set.
core_user::reset_internal_users();
\core_user::reset_internal_users();
$CFG->supportemail = '[email protected]';
$supportuser = core_user::get_support_user();
$this->assertEquals(core_user::SUPPORT_USER, $supportuser->id);
$this->assertFalse(core_user::is_real_user($supportuser->id));
$supportuser = \core_user::get_support_user();
$this->assertEquals(\core_user::SUPPORT_USER, $supportuser->id);
$this->assertFalse(\core_user::is_real_user($supportuser->id));
// Set user as support user and make sure noreply propery is set.
core_user::reset_internal_users();
\core_user::reset_internal_users();
$CFG->supportuserid = $user->id;
$supportuser = core_user::get_support_user();
$supportuser = \core_user::get_support_user();
$this->assertEquals($user, $supportuser);
$this->assertTrue(core_user::is_real_user($supportuser->id));
$this->assertTrue(\core_user::is_real_user($supportuser->id));
}
/**
@@ -98,23 +92,23 @@ class core_user_testcase extends advanced_testcase {
$userexpected = $this->getDataGenerator()->create_user($record);
// Assert that the returned user is the espected one.
$this->assertEquals($userexpected, core_user::get_user_by_username('johndoe'));
$this->assertEquals($userexpected, \core_user::get_user_by_username('johndoe'));
// Assert that a subset of fields is correctly returned.
$this->assertEquals((object) $record, core_user::get_user_by_username('johndoe', 'username,email,timecreated'));
$this->assertEquals((object) $record, \core_user::get_user_by_username('johndoe', 'username,email,timecreated'));
// Assert that a user with a different mnethostid will no be returned.
$this->assertFalse(core_user::get_user_by_username('johndoe', 'username,email,timecreated', 2));
$this->assertFalse(\core_user::get_user_by_username('johndoe', 'username,email,timecreated', 2));
// Create a new user from a different host.
$record['mnethostid'] = 2;
$userexpected2 = $this->getDataGenerator()->create_user($record);
// Assert that the new user is returned when specified the correct mnethostid.
$this->assertEquals($userexpected2, core_user::get_user_by_username('johndoe', '*', 2));
$this->assertEquals($userexpected2, \core_user::get_user_by_username('johndoe', '*', 2));
// Assert that a user not in the db return false.
$this->assertFalse(core_user::get_user_by_username('janedoe'));
$this->assertFalse(\core_user::get_user_by_username('janedoe'));
}
public function test_search() {
@@ -174,7 +168,7 @@ class core_user_testcase extends advanced_testcase {
// As admin user, try searching for somebody at system level by first name, checking the
// results.
$this->setAdminUser();
$result = core_user::search('Amelia');
$result = \core_user::search('Amelia');
$this->assertCount(1, $result);
// Check some basic fields, and test other fields are present.
@@ -191,22 +185,22 @@ class core_user_testcase extends advanced_testcase {
$this->assertObjectHasAttribute('username', $result[0]);
// Now search by lastname, both names, and partials, case-insensitive.
$this->assertEquals($result, core_user::search('House'));
$this->assertEquals($result, core_user::search('Amelia house'));
$this->assertEquals($result, core_user::search('amelI'));
$this->assertEquals($result, core_user::search('hoUs'));
$this->assertEquals($result, core_user::search('Amelia H'));
$this->assertEquals($result, \core_user::search('House'));
$this->assertEquals($result, \core_user::search('Amelia house'));
$this->assertEquals($result, \core_user::search('amelI'));
$this->assertEquals($result, \core_user::search('hoUs'));
$this->assertEquals($result, \core_user::search('Amelia H'));
// Admin user can also search by email (full or partial).
$this->assertEquals($result, core_user::search('[email protected]'));
$this->assertEquals($result, core_user::search('hOuse@'));
$this->assertEquals($result, \core_user::search('[email protected]'));
$this->assertEquals($result, \core_user::search('hOuse@'));
// What if we just search for A? (They all begin with A except the manager.)
$result = core_user::search('a');
$result = \core_user::search('a');
$this->assertCount(7, $result);
// Au gets us Audrey, Austin, and Augustus - in alphabetical order by surname.
$result = core_user::search('au');
$result = \core_user::search('au');
$this->assertCount(3, $result);
$this->assertEquals('Austin', $result[0]->firstname);
$this->assertEquals('Audrey', $result[1]->firstname);
@@ -214,7 +208,7 @@ class core_user_testcase extends advanced_testcase {
// But if we search within course 2 we'll get Audrey and Augustus first.
$course2context = \context_course::instance($course2->id);
$result = core_user::search('au', $course2context);
$result = \core_user::search('au', $course2context);
$this->assertCount(3, $result);
$this->assertEquals('Audrey', $result[0]->firstname);
$this->assertEquals('Augustus', $result[1]->firstname);
@@ -223,69 +217,69 @@ class core_user_testcase extends advanced_testcase {
// Try doing a few searches as manager - we should get the same results and can still
// search by email too.
$this->setUser($manager);
$result = core_user::search('a');
$result = \core_user::search('a');
$this->assertCount(7, $result);
$result = core_user::search('au', $course2context);
$result = \core_user::search('au', $course2context);
$this->assertCount(3, $result);
$result = core_user::search('[email protected]');
$result = \core_user::search('[email protected]');
$this->assertCount(1, $result);
// Teacher 1. No site-level permission so can't see users outside the enrolled course.
$this->setUser($teacher1);
$result = core_user::search('au');
$result = \core_user::search('au');
$this->assertCount(1, $result);
$this->assertEquals('Augustus', $result[0]->firstname);
// Can still search by email for that user.
$result = core_user::search('[email protected]');
$result = \core_user::search('[email protected]');
$this->assertCount(1, $result);
// Search everyone - teacher can only see four users (including themself).
$result = core_user::search('a');
$result = \core_user::search('a');
$this->assertCount(4, $result);
// Search within course 2 - you get the same four users (which doesn't include
// everyone on that course) but the two on course 2 should be first.
$result = core_user::search('a', $course2context);
$result = \core_user::search('a', $course2context);
$this->assertCount(4, $result);
$this->assertEquals('Amelia', $result[0]->firstname);
$this->assertEquals('Augustus', $result[1]->firstname);
// Other teacher.
$this->setUser($teacher2and3);
$result = core_user::search('au');
$result = \core_user::search('au');
$this->assertCount(3, $result);
$result = core_user::search('a');
$result = \core_user::search('a');
$this->assertCount(5, $result);
// Student can only see users on course 3.
$this->setUser($student3);
$result = core_user::search('a');
$result = \core_user::search('a');
$this->assertCount(3, $result);
$result = core_user::search('au');
$result = \core_user::search('au');
$this->assertCount(1, $result);
$this->assertEquals('Austin', $result[0]->firstname);
// Student cannot search by email.
$result = core_user::search('[email protected]');
$result = \core_user::search('[email protected]');
$this->assertCount(0, $result);
// Student on all courses can see all the A users.
$this->setUser($studentall);
$result = core_user::search('a');
$result = \core_user::search('a');
$this->assertCount(7, $result);
// Mixed user can see users on courses 1 and 3.
$this->setUser($mixed);
$result = core_user::search('a');
$result = \core_user::search('a');
$this->assertCount(6, $result);
// Mixed user can search by email for students on course 3 but not on course 1.
$result = core_user::search('[email protected]');
$result = \core_user::search('[email protected]');
$this->assertCount(0, $result);
$result = core_user::search('[email protected]');
$result = \core_user::search('[email protected]');
$this->assertCount(1, $result);
}
@@ -304,15 +298,15 @@ class core_user_testcase extends advanced_testcase {
$generator->enrol_user($student->id, $course->id, 'student');
}
$this->setAdminUser();
$result = core_user::search('Guy');
$result = \core_user::search('Guy');
$this->assertCount(30, $result);
// Check a small limit.
$result = core_user::search('Guy', null, 10);
$result = \core_user::search('Guy', null, 10);
$this->assertCount(10, $result);
// Check no limit.
$result = core_user::search('Guy', null, 0);
$result = \core_user::search('Guy', null, 0);
$this->assertCount(31, $result);
}
@@ -350,12 +344,12 @@ class core_user_testcase extends advanced_testcase {
// As searcher, we only find the 2 in the same group.
$this->setUser($searcher);
$result = core_user::search('Guy');
$result = \core_user::search('Guy');
$this->assertCount(2, $result);
// If we change the course to visible groups though, we get the max number.
$DB->set_field('course', 'groupmode', VISIBLEGROUPS, ['id' => $course->id]);
$result = core_user::search('Guy');
$result = \core_user::search('Guy');
$this->assertCount(30, $result);
}
@@ -382,18 +376,18 @@ class core_user_testcase extends advanced_testcase {
// As searcher, we find both users.
$this->setUser($searcher);
$result = core_user::search('Amelia');
$result = \core_user::search('Amelia');
$this->assertCount(2, $result);
// What if one is deleted?
delete_user($student1);
$result = core_user::search('Amelia');
$result = \core_user::search('Amelia');
$this->assertCount(1, $result);
$this->assertEquals('Beetle', $result[0]->lastname);
// Delete the other, for good measure.
delete_user($student2);
$result = core_user::search('Amelia');
$result = \core_user::search('Amelia');
$this->assertCount(0, $result);
}
@@ -425,13 +419,13 @@ class core_user_testcase extends advanced_testcase {
$userexpected = $this->getDataGenerator()->create_user();
// Simple case, all good.
core_user::require_active_user($userexpected, true, true);
\core_user::require_active_user($userexpected, true, true);
// Set user not confirmed.
$DB->set_field('user', 'confirmed', 0, array('id' => $userexpected->id));
try {
core_user::require_active_user($userexpected);
} catch (moodle_exception $e) {
\core_user::require_active_user($userexpected);
} catch (\moodle_exception $e) {
$this->assertEquals('usernotconfirmed', $e->errorcode);
}
$DB->set_field('user', 'confirmed', 1, array('id' => $userexpected->id));
@@ -439,45 +433,45 @@ class core_user_testcase extends advanced_testcase {
// Set nologin auth method.
$DB->set_field('user', 'auth', 'nologin', array('id' => $userexpected->id));
try {
core_user::require_active_user($userexpected, false, true);
} catch (moodle_exception $e) {
\core_user::require_active_user($userexpected, false, true);
} catch (\moodle_exception $e) {
$this->assertEquals('suspended', $e->errorcode);
}
// Check no exceptions are thrown if we don't specify to check suspended.
core_user::require_active_user($userexpected);
\core_user::require_active_user($userexpected);
$DB->set_field('user', 'auth', 'manual', array('id' => $userexpected->id));
// Set user suspended.
$DB->set_field('user', 'suspended', 1, array('id' => $userexpected->id));
try {
core_user::require_active_user($userexpected, true);
} catch (moodle_exception $e) {
\core_user::require_active_user($userexpected, true);
} catch (\moodle_exception $e) {
$this->assertEquals('suspended', $e->errorcode);
}
// Check no exceptions are thrown if we don't specify to check suspended.
core_user::require_active_user($userexpected);
\core_user::require_active_user($userexpected);
// Delete user.
delete_user($userexpected);
try {
core_user::require_active_user($userexpected);
} catch (moodle_exception $e) {
\core_user::require_active_user($userexpected);
} catch (\moodle_exception $e) {
$this->assertEquals('userdeleted', $e->errorcode);
}
// Use a not real user.
$noreplyuser = core_user::get_noreply_user();
$noreplyuser = \core_user::get_noreply_user();
try {
core_user::require_active_user($noreplyuser, true);
} catch (moodle_exception $e) {
\core_user::require_active_user($noreplyuser, true);
} catch (\moodle_exception $e) {
$this->assertEquals('invaliduser', $e->errorcode);
}
// Get the guest user.
$guestuser = $DB->get_record('user', array('username' => 'guest'));
try {
core_user::require_active_user($guestuser, true);
} catch (moodle_exception $e) {
\core_user::require_active_user($guestuser, true);
} catch (\moodle_exception $e) {
$this->assertEquals('guestsarenotallowed', $e->errorcode);
}
@@ -488,22 +482,22 @@ class core_user_testcase extends advanced_testcase {
*/
public function test_get_property_definition() {
// Try to get a existing property.
$properties = core_user::get_property_definition('id');
$properties = \core_user::get_property_definition('id');
$this->assertEquals($properties['type'], PARAM_INT);
$properties = core_user::get_property_definition('username');
$properties = \core_user::get_property_definition('username');
$this->assertEquals($properties['type'], PARAM_USERNAME);
// Invalid property.
try {
core_user::get_property_definition('fullname');
} catch (coding_exception $e) {
\core_user::get_property_definition('fullname');
} catch (\coding_exception $e) {
$this->assertMatchesRegularExpression('/Invalid property requested./', $e->getMessage());
}
// Empty parameter.
try {
core_user::get_property_definition('');
} catch (coding_exception $e) {
\core_user::get_property_definition('');
} catch (\coding_exception $e) {
$this->assertMatchesRegularExpression('/Invalid property requested./', $e->getMessage());
}
}
@@ -515,7 +509,7 @@ class core_user_testcase extends advanced_testcase {
// Create user with just with username and firstname.
$record = array('username' => 's10', 'firstname' => 'Bebe Stevens');
$validation = core_user::validate((object)$record);
$validation = \core_user::validate((object)$record);
// Validate the user, should return true as the user data is correct.
$this->assertTrue($validation);
@@ -524,7 +518,7 @@ class core_user_testcase extends advanced_testcase {
$record = array('username' => 's1', 'firstname' => 'Eric Cartman', 'country' => 'UU', 'theme' => 'beise');
// Should return an array with 2 errors.
$validation = core_user::validate((object)$record);
$validation = \core_user::validate((object)$record);
$this->assertArrayHasKey('country', $validation);
$this->assertArrayHasKey('theme', $validation);
$this->assertCount(2, $validation);
@@ -533,7 +527,7 @@ class core_user_testcase extends advanced_testcase {
$record = array('username' => 's3', 'firstname' => 'Kyle<script>alert(1);<script> Broflovski');
// Should return an array with 1 error.
$validation = core_user::validate((object)$record);
$validation = \core_user::validate((object)$record);
$this->assertCount(1, $validation);
$this->assertArrayHasKey('firstname', $validation);
}
@@ -544,13 +538,13 @@ class core_user_testcase extends advanced_testcase {
public function test_clean_data() {
$this->resetAfterTest(false);
$user = new stdClass();
$user = new \stdClass();
$user->firstname = 'John <script>alert(1)</script> Doe';
$user->username = 'john%#&~%*_doe';
$user->email = ' [email protected] ';
$user->deleted = 'no';
$user->description = '<b>A description <script>alert(123);</script>about myself.</b>';
$usercleaned = core_user::clean_data($user);
$usercleaned = \core_user::clean_data($user);
// Expected results.
$this->assertEquals('John alert(1) Doe', $usercleaned->firstname);
@@ -561,7 +555,7 @@ class core_user_testcase extends advanced_testcase {
// Try to clean an invalid property (userfullname).
$user->userfullname = 'John Doe';
core_user::clean_data($user);
\core_user::clean_data($user);
$this->assertDebuggingCalled("The property 'userfullname' could not be cleaned.");
}
@@ -571,7 +565,7 @@ class core_user_testcase extends advanced_testcase {
public function test_clean_field() {
// Create a 'malicious' user object/
$user = new stdClass();
$user = new \stdClass();
$user->firstname = 'John <script>alert(1)</script> Doe';
$user->username = 'john%#&~%*_doe';
$user->email = ' [email protected] ';
@@ -580,14 +574,14 @@ class core_user_testcase extends advanced_testcase {
$user->userfullname = 'John Doe';
// Expected results.
$this->assertEquals('John alert(1) Doe', core_user::clean_field($user->firstname, 'firstname'));
$this->assertEquals('john_doe', core_user::clean_field($user->username, 'username'));
$this->assertEquals('[email protected]', core_user::clean_field($user->email, 'email'));
$this->assertEquals(0, core_user::clean_field($user->deleted, 'deleted'));
$this->assertEquals('<b>A description <script>alert(123);</script>about myself.</b>', core_user::clean_field($user->description, 'description'));
$this->assertEquals('John alert(1) Doe', \core_user::clean_field($user->firstname, 'firstname'));
$this->assertEquals('john_doe', \core_user::clean_field($user->username, 'username'));
$this->assertEquals('[email protected]', \core_user::clean_field($user->email, 'email'));
$this->assertEquals(0, \core_user::clean_field($user->deleted, 'deleted'));
$this->assertEquals('<b>A description <script>alert(123);</script>about myself.</b>', \core_user::clean_field($user->description, 'description'));
// Try to clean an invalid property (fullname).
core_user::clean_field($user->userfullname, 'fullname');
\core_user::clean_field($user->userfullname, 'fullname');
$this->assertDebuggingCalled("The property 'fullname' could not be cleaned.");
}
@@ -597,21 +591,21 @@ class core_user_testcase extends advanced_testcase {
public function test_get_property_type() {
// Fetch valid properties and verify if the type is correct.
$type = core_user::get_property_type('username');
$type = \core_user::get_property_type('username');
$this->assertEquals(PARAM_USERNAME, $type);
$type = core_user::get_property_type('email');
$type = \core_user::get_property_type('email');
$this->assertEquals(PARAM_RAW_TRIMMED, $type);
$type = core_user::get_property_type('timezone');
$type = \core_user::get_property_type('timezone');
$this->assertEquals(PARAM_TIMEZONE, $type);
// Try to fetch type of a non-existent properties.
$nonexistingproperty = 'userfullname';
$this->expectException('coding_exception');
$this->expectExceptionMessage('Invalid property requested: ' . $nonexistingproperty);
core_user::get_property_type($nonexistingproperty);
\core_user::get_property_type($nonexistingproperty);
$nonexistingproperty = 'mobilenumber';
$this->expectExceptionMessage('Invalid property requested: ' . $nonexistingproperty);
core_user::get_property_type($nonexistingproperty);
\core_user::get_property_type($nonexistingproperty);
}
/**
@@ -619,23 +613,23 @@ class core_user_testcase extends advanced_testcase {
*/
public function test_get_property_null() {
// Fetch valid properties and verify if it is NULL_ALLOWED or NULL_NOT_ALLOWED.
$property = core_user::get_property_null('username');
$property = \core_user::get_property_null('username');
$this->assertEquals(NULL_NOT_ALLOWED, $property);
$property = core_user::get_property_null('password');
$property = \core_user::get_property_null('password');
$this->assertEquals(NULL_NOT_ALLOWED, $property);
$property = core_user::get_property_null('imagealt');
$property = \core_user::get_property_null('imagealt');
$this->assertEquals(NULL_ALLOWED, $property);
$property = core_user::get_property_null('middlename');
$property = \core_user::get_property_null('middlename');
$this->assertEquals(NULL_ALLOWED, $property);
// Try to fetch type of a non-existent properties.
$nonexistingproperty = 'lastnamefonetic';
$this->expectException('coding_exception');
$this->expectExceptionMessage('Invalid property requested: ' . $nonexistingproperty);
core_user::get_property_null($nonexistingproperty);
\core_user::get_property_null($nonexistingproperty);
$nonexistingproperty = 'midlename';
$this->expectExceptionMessage('Invalid property requested: ' . $nonexistingproperty);
core_user::get_property_null($nonexistingproperty);
\core_user::get_property_null($nonexistingproperty);
}
/**
@@ -644,20 +638,20 @@ class core_user_testcase extends advanced_testcase {
public function test_get_property_choices() {
// Test against country property choices.
$choices = core_user::get_property_choices('country');
$choices = \core_user::get_property_choices('country');
$this->assertArrayHasKey('AU', $choices);
$this->assertArrayHasKey('BR', $choices);
$this->assertArrayNotHasKey('WW', $choices);
$this->assertArrayNotHasKey('TX', $choices);
// Test against lang property choices.
$choices = core_user::get_property_choices('lang');
$choices = \core_user::get_property_choices('lang');
$this->assertArrayHasKey('en', $choices);
$this->assertArrayNotHasKey('ww', $choices);
$this->assertArrayNotHasKey('yy', $choices);
// Test against theme property choices.
$choices = core_user::get_property_choices('theme');
$choices = \core_user::get_property_choices('theme');
$this->assertArrayHasKey('boost', $choices);
$this->assertArrayHasKey('classic', $choices);
$this->assertArrayNotHasKey('unknowntheme', $choices);
@@ -667,10 +661,10 @@ class core_user_testcase extends advanced_testcase {
$nonexistingproperty = 'language';
$this->expectException('coding_exception');
$this->expectExceptionMessage('Invalid property requested: ' . $nonexistingproperty);
core_user::get_property_null($nonexistingproperty);
\core_user::get_property_null($nonexistingproperty);
$nonexistingproperty = 'coutries';
$this->expectExceptionMessage('Invalid property requested: ' . $nonexistingproperty);
core_user::get_property_null($nonexistingproperty);
\core_user::get_property_null($nonexistingproperty);
}
/**
@@ -680,31 +674,31 @@ class core_user_testcase extends advanced_testcase {
global $CFG;
$this->resetAfterTest();
$country = core_user::get_property_default('country');
$country = \core_user::get_property_default('country');
$this->assertEquals($CFG->country, $country);
set_config('country', 'AU');
core_user::reset_caches();
$country = core_user::get_property_default('country');
\core_user::reset_caches();
$country = \core_user::get_property_default('country');
$this->assertEquals($CFG->country, $country);
$lang = core_user::get_property_default('lang');
$lang = \core_user::get_property_default('lang');
$this->assertEquals($CFG->lang, $lang);
set_config('lang', 'en');
$lang = core_user::get_property_default('lang');
$lang = \core_user::get_property_default('lang');
$this->assertEquals($CFG->lang, $lang);
$this->setTimezone('Europe/London', 'Pacific/Auckland');
core_user::reset_caches();
$timezone = core_user::get_property_default('timezone');
\core_user::reset_caches();
$timezone = \core_user::get_property_default('timezone');
$this->assertEquals('Europe/London', $timezone);
$this->setTimezone('99', 'Pacific/Auckland');
core_user::reset_caches();
$timezone = core_user::get_property_default('timezone');
\core_user::reset_caches();
$timezone = \core_user::get_property_default('timezone');
$this->assertEquals('Pacific/Auckland', $timezone);
$this->expectException(coding_exception::class);
$this->expectException(\coding_exception::class);
$this->expectExceptionMessage('Invalid property requested, or the property does not has a default value.');
core_user::get_property_default('firstname');
\core_user::get_property_default('firstname');
}
/**
@@ -762,12 +756,12 @@ class core_user_testcase extends advanced_testcase {
// Fake accounts are not real users.
$CFG->noreplyuserid = null;
$this->assertFalse(\core_user::is_real_user(core_user::get_noreply_user()->id));
$this->assertFalse(\core_user::is_real_user(core_user::get_noreply_user()->id, true));
$this->assertFalse(\core_user::is_real_user(\core_user::get_noreply_user()->id));
$this->assertFalse(\core_user::is_real_user(\core_user::get_noreply_user()->id, true));
$CFG->supportuserid = null;
$CFG->supportemail = '[email protected]';
$this->assertFalse(\core_user::is_real_user(core_user::get_support_user()->id));
$this->assertFalse(\core_user::is_real_user(core_user::get_support_user()->id, true));
$this->assertFalse(\core_user::is_real_user(\core_user::get_support_user()->id));
$this->assertFalse(\core_user::is_real_user(\core_user::get_support_user()->id, true));
}
/**