From 5be632e8b60a034f658d5dfe3c3353a33f9dd6ca Mon Sep 17 00:00:00 2001 From: Damyon Wiese Date: Thu, 17 Jan 2013 11:05:31 +0800 Subject: [PATCH] MDL-37543 Assignment upgrade: convert advanced upload files "Send for marking" setting Advanced upload files assignment type has "Enable send for marking" setting instead of "Allow resubmissions". Needs special handling in upgrade code to convert to "Require students click submit button". Conflicts: mod/assign/submission/file/locallib.php --- mod/assign/submission/file/locallib.php | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/mod/assign/submission/file/locallib.php b/mod/assign/submission/file/locallib.php index ed1e23471dc..6e0f5c5ea6a 100644 --- a/mod/assign/submission/file/locallib.php +++ b/mod/assign/submission/file/locallib.php @@ -301,14 +301,21 @@ class assign_submission_file extends assign_submission_plugin { * @return bool Was it a success? (false will trigger rollback) */ public function upgrade_settings(context $oldcontext,stdClass $oldassignment, & $log) { + global $DB; + if ($oldassignment->assignmenttype == 'uploadsingle') { $this->set_config('maxfilesubmissions', 1); $this->set_config('maxsubmissionsizebytes', $oldassignment->maxbytes); return true; - }else { - + } else if ($oldassignment->assignmenttype == 'upload') { $this->set_config('maxfilesubmissions', $oldassignment->var1); $this->set_config('maxsubmissionsizebytes', $oldassignment->maxbytes); + + // Advanced file upload uses a different setting to do the same thing. + $DB->set_field('assign', + 'submissiondrafts', + $oldassignment->var4, + array('id'=>$this->assignment->get_instance()->id)); return true; }