MDL-35238 Fix the unit test for invalid input_manager::TYPE_URL values

2012-11-08 22:33:07 +01:00
parent b10b1e728d
commit 5bd9b0ae62
1 changed files with 9 additions and 1 deletions
@@ -134,7 +134,6 @@ class mdeploytest extends PHPUnit_Framework_TestCase {
                input_manager::TYPE_URL,
                'https://moodle.org/plugins/download.php/1292/mod_stampcoll_moodle23_2012062201.zip'
            ),
-            array('file:///etc/passwd', input_manager::TYPE_URL, ''),

            array('5e8d2ea4f50d154730100b1645fbad67', input_manager::TYPE_MD5, '5e8d2ea4f50d154730100b1645fbad67'),
        );
@@ -157,6 +156,15 @@ class mdeploytest extends PHPUnit_Framework_TestCase {
        $input->cast_value($o, input_manager::TYPE_INT); // must throw exception
    }

+    /**
+     * @expectedException invalid_option_exception
+     */
+    public function test_cast_invalid_url_value() {
+        $input = testable_input_manager::instance();
+        $invalid = 'file:///etc/passwd';
+        $input->cast_value($invalid, input_manager::TYPE_URL); // must throw exception
+    }
+
    /**
     * @expectedException invalid_option_exception
     */