MDL-40612 libraries: Tidy up and improvement of the code for additional name fields.

Includes an update to get_all_user_name_fields() and the inclusion of set_user_name_object()
This commit is contained in:
Adrian Greeve
2013-11-11 11:01:14 +08:00
parent f490f988b7
commit 5b1944bbba
10 changed files with 88 additions and 112 deletions
+2 -18
View File
@@ -559,15 +559,7 @@ class question_bank_creator_name_column extends question_bank_column_base {
protected function display_content($question, $rowclasses) {
if (!empty($question->creatorfirstname) && !empty($question->creatorlastname)) {
$u = new stdClass();
$allnames = get_all_user_name_fields();
foreach ($allnames as $allname) {
$tempname = 'creator' . $allname;
if (isset($question->$tempname)) {
$u->$allname = $question->$tempname;
} else {
$u->$allname = '';
}
}
$u = username_load_fields_from_object($u, $question, 'creator');
echo fullname($u);
}
}
@@ -612,15 +604,7 @@ class question_bank_modifier_name_column extends question_bank_column_base {
protected function display_content($question, $rowclasses) {
if (!empty($question->modifierfirstname) && !empty($question->modifierlastname)) {
$u = new stdClass();
$allnames = get_all_user_name_fields();
foreach ($allnames as $allname) {
$tempname = 'modifier' . $allname;
if (isset($question->$tempname)) {
$u->$allname = $question->$tempname;
} else {
$u->$allname = '';
}
}
$u = username_load_fields_from_object($u, $question, 'modifier');
echo fullname($u);
}
}