L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-67309 login: Added check for password policy at login time.

Browse Source
This commit is contained in:
Peter Burnett
2020-02-17 09:55:07 +10:00
parent cb38ab1e39
commit 59298ccebc
6 changed files with 211 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/tests/authlib_test.php
+69
View File
@@ -335,6 +335,75 @@ class core_authlib_testcase extends advanced_testcase {
$this->assertEquals(AUTH_LOGIN_OK, $reason);
ini_set('error_log', $oldlog);
// Test password policy check on login.
$CFG->passwordpolicy = 0;
$CFG->passwordpolicycheckonlogin = 1;
// First test with password policy disabled.
$user4 = $this->getDataGenerator()->create_user(array('username' => 'username4', 'password' => 'a'));
$sink = $this->redirectEvents();
$reason = null;
$result = authenticate_user_login('username4', 'a', false, $reason);
$events = $sink->get_events();
$sink->close();
$notifications = \core\notification::fetch();
$this->assertInstanceOf('stdClass', $result);
$this->assertEquals(AUTH_LOGIN_OK, $reason);
$this->assertEquals(get_user_preferences('auth_forcepasswordchange', false, $result), false);
// Check no events.
$this->assertEquals(count($events), 0);
// Check no notifications.
$this->assertEquals(count($notifications), 0);
// Now test with the password policy enabled, flip reset flag.
$sink = $this->redirectEvents();
$reason = null;
$CFG->passwordpolicy = 1;
$result = authenticate_user_login('username4', 'a', false, $reason);
$events = $sink->get_events();
$sink->close();
$this->assertInstanceOf('stdClass', $result);
$this->assertEquals(AUTH_LOGIN_OK, $reason);
$this->assertEquals(get_user_preferences('auth_forcepasswordchange', true, $result), true);
// Check that an event was emitted for the policy failure.
$this->assertEquals(count($events), 1);
$this->assertEquals(reset($events)->eventname, '\core\event\user_password_policy_failed');
// Check notification fired.
$notifications = \core\notification::fetch();
$this->assertEquals(count($notifications), 1);
// Now the same tests with a user that passes the password policy.
$user5 = $this->getDataGenerator()->create_user(array('username' => 'username5', 'password' => 'ThisPassword1sSecure!'));
$reason = null;
$CFG->passwordpolicy = 0;
$sink = $this->redirectEvents();
$result = authenticate_user_login('username5', 'ThisPassword1sSecure!', false, $reason);
$events = $sink->get_events();
$sink->close();
$notifications = \core\notification::fetch();
$this->assertInstanceOf('stdClass', $result);
$this->assertEquals(AUTH_LOGIN_OK, $reason);
$this->assertEquals(get_user_preferences('auth_forcepasswordchange', false, $result), false);
// Check no events.
$this->assertEquals(count($events), 0);
// Check no notifications.
$this->assertEquals(count($notifications), 0);
$reason = null;
$CFG->passwordpolicy = 1;
$sink = $this->redirectEvents();
$result = authenticate_user_login('username5', 'ThisPassword1sSecure!', false, $reason);
$events = $sink->get_events();
$sink->close();
$notifications = \core\notification::fetch();
$this->assertInstanceOf('stdClass', $result);
$this->assertEquals(AUTH_LOGIN_OK, $reason);
$this->assertEquals(get_user_preferences('auth_forcepasswordchange', false, $result), false);
// Check no events.
$this->assertEquals(count($events), 0);
// Check no notifications.
$this->assertEquals(count($notifications), 0);
}
public function test_user_loggedin_event_exceptions() {