From 56cd63a8f9d7ae7dfdd7bd7688ee77fbb3785cdb Mon Sep 17 00:00:00 2001
From: Paul Holden <paulh@moodle.com>
Date: Wed, 26 Jul 2023 16:58:57 +0100
Subject: [PATCH] MDL-71494 mod_feedback: final removal of deprecated
 constructor param.

---
 mod/feedback/classes/output/summary.php | 7 +------
 mod/feedback/upgrade.txt                | 7 +++++++
 2 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/mod/feedback/classes/output/summary.php b/mod/feedback/classes/output/summary.php
index 5beda91033e..9231e12ebe6 100644
--- a/mod/feedback/classes/output/summary.php
+++ b/mod/feedback/classes/output/summary.php
@@ -49,15 +49,10 @@ class summary implements renderable, templatable {
     /**
      * Constructor.
      *
-     * @todo MDL-71494 Final deprecation of the $extradetails parameter in Moodle 4.3
      * @param mod_feedback_structure $feedbackstructure
      * @param int $mygroupid currently selected group
-     * @param bool|null $extradetails Deprecated
      */
-    public function __construct($feedbackstructure, $mygroupid = false, $extradetails = null) {
-        if (isset($extradetails)) {
-            debugging('The $extradetails parameter is deprecated.', DEBUG_DEVELOPER);
-        }
+    public function __construct($feedbackstructure, $mygroupid = false) {
         $this->feedbackstructure = $feedbackstructure;
         $this->mygroupid = $mygroupid;
     }
diff --git a/mod/feedback/upgrade.txt b/mod/feedback/upgrade.txt
index 5d8b692ae8d..e276dfc8411 100644
--- a/mod/feedback/upgrade.txt
+++ b/mod/feedback/upgrade.txt
@@ -1,3 +1,10 @@
+This file describes API changes in /mod/feedback/*
+Information provided here is intended especially for developers.
+
+=== 4.3 ===
+
+* The `$extradetails` parameter of the `\mod_feedback\output\summary` class constructor has been removed
+
 === 4.2 ===
 * The external methods get_items() and get_page_items() now only return the items when the user can access the feedback; if the
 user can't see them, a warning message will be returned, with the reasons.