diff --git a/course/classes/reportbuilder/local/entities/enrolment.php b/course/classes/reportbuilder/local/entities/enrolment.php index c55e3141770..9eafb2417c2 100644 --- a/course/classes/reportbuilder/local/entities/enrolment.php +++ b/course/classes/reportbuilder/local/entities/enrolment.php @@ -149,7 +149,6 @@ class enrolment extends base { ->add_joins($this->get_joins()) ->set_type(column::TYPE_TEXT) ->add_field($this->get_status_field_sql(), 'status') - ->add_field("{$userenrolments}.userid") ->set_is_sortable(true) ->add_callback([enrolment_formatter::class, 'enrolment_status']); @@ -200,7 +199,7 @@ class enrolment extends base { THEN " . status_field::STATUS_NOT_CURRENT . " ELSE " . status_field::STATUS_ACTIVE . " END - ELSE " . status_field::STATUS_SUSPENDED . " + ELSE {$userenrolments}.status END"; } diff --git a/course/classes/reportbuilder/local/formatters/enrolment.php b/course/classes/reportbuilder/local/formatters/enrolment.php index fb97e74f935..b502c903885 100644 --- a/course/classes/reportbuilder/local/formatters/enrolment.php +++ b/course/classes/reportbuilder/local/formatters/enrolment.php @@ -67,14 +67,14 @@ class enrolment { /** * Return enrolment status for user * - * @param string $value - * @param stdClass $row + * @param string|null $value * @return string|null */ - public static function enrolment_status(string $value, stdClass $row): ?string { - if (!$row->userid) { + public static function enrolment_status(?string $value): ?string { + if ($value === null) { return null; } + $statusvalues = self::enrolment_values(); $value = (int) $value;