From 548796db5007bb36849b04fddbf2747924e67f4a Mon Sep 17 00:00:00 2001
From: Jun Pataleta <jun@moodle.com>
Date: Tue, 16 Apr 2024 15:35:46 +0800
Subject: [PATCH] MDL-81556 tiny_media: Remove unnecessary labels

* Remove usage of label tags that are not associated with any
 form elements.
* Remove setting of title for the label tags. This is not necessary
as the title text is the same as the text showed in the label.
---
 .../templates/insert_image_modal_details_footer.mustache     | 2 +-
 .../templates/insert_image_modal_insert_footer.mustache      | 5 ++---
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/lib/editor/tiny/plugins/media/templates/insert_image_modal_details_footer.mustache b/lib/editor/tiny/plugins/media/templates/insert_image_modal_details_footer.mustache
index d4beb9c9fee..574fbc0ca8b 100644
--- a/lib/editor/tiny/plugins/media/templates/insert_image_modal_details_footer.mustache
+++ b/lib/editor/tiny/plugins/media/templates/insert_image_modal_details_footer.mustache
@@ -29,7 +29,7 @@
     <!-- First Column -->
     <div class="col-md-6 d-flex align-items-center p-0">
         <!-- Row 1: URL related label -->
-        <label title="{{#str}} filename, tiny_media {{/str}}" class="tiny_image_filename text-truncate mr-1">{{#str}} filename, tiny_media {{/str}}</label>
+        <span class="tiny_image_filename text-truncate mr-1"></span>
     </div>
     <!-- Column 2: Saving, canceling, browsing repositories buttons -->
     <div class="col-md-6 text-right mt-2 md-0 p-0">
diff --git a/lib/editor/tiny/plugins/media/templates/insert_image_modal_insert_footer.mustache b/lib/editor/tiny/plugins/media/templates/insert_image_modal_insert_footer.mustache
index aa7e1434e96..3284935c58f 100644
--- a/lib/editor/tiny/plugins/media/templates/insert_image_modal_insert_footer.mustache
+++ b/lib/editor/tiny/plugins/media/templates/insert_image_modal_insert_footer.mustache
@@ -33,12 +33,11 @@
     <div class="col-md-6 d-flex align-items-center p-0">
         <!-- Row 1: URL related label -->
         {{#showdropzone}}
-        <label for="{{elementid}}_tiny_image_urlentry" title="{{#str}} enterurlor, tiny_media {{/str}}" class="tiny_image_url_label mr-1">{{#str}} enterurlor, tiny_media {{/str}}</label>
+        <label for="{{elementid}}_tiny_image_urlentry" class="tiny_image_url_label mr-1">{{#str}} enterurlor, tiny_media {{/str}}</label>
         {{/showdropzone}}
         {{^showdropzone}}
-        <label for="{{elementid}}_tiny_image_urlentry" title="{{#str}} enterurl, tiny_media {{/str}}" class="tiny_image_url_label mr-1">{{#str}} enterurl, tiny_media {{/str}}</label>
+        <label for="{{elementid}}_tiny_image_urlentry" class="tiny_image_url_label mr-1">{{#str}} enterurl, tiny_media {{/str}}</label>
         {{/showdropzone}}
-        <label title="{{#str}} filename, tiny_media {{/str}}" class="d-none tiny_image_filename text-truncate mr-1">{{#str}} filename, tiny_media {{/str}}</label>
         <!-- Row 2: URL entry input. Needed by the insert image step and image details step if the image URL source from external -->
         <input name="urlentry" class="tiny_image_urlentry form-control w-50 mr-1" type="url" id="{{elementid}}_tiny_image_urlentry" size="32" value="{{src}}">
         <!-- Row 3: Add button. Needed by the insert image step -->