From 5452309a58131ba6b46899dca5bc84e259e81d25 Mon Sep 17 00:00:00 2001 From: David Mudrak Date: Fri, 17 Sep 2010 13:26:10 +0000 Subject: [PATCH] NOMDL workshop: improved SQL execution, use one query instead of loop --- mod/workshop/db/upgrade.php | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/mod/workshop/db/upgrade.php b/mod/workshop/db/upgrade.php index 1f5410c624c..e069094e26f 100644 --- a/mod/workshop/db/upgrade.php +++ b/mod/workshop/db/upgrade.php @@ -51,9 +51,7 @@ function xmldb_workshop_upgrade($oldversion) { WHERE ws.id IS NULL'); if (!empty($orphans)) { echo $OUTPUT->notification('Orphaned assessment records found - cleaning...'); - foreach (array_keys($orphans) as $waid) { - $DB->delete_records('workshop_assessments', 'id', $waid); - } + $DB->delete_records_list('workshop_assessments', 'id', array_keys($orphans)); } upgrade_mod_savepoint(true, 2007101510, 'workshop'); }