From 54226e8157517c7b00a91bcc6ea8d4a7a6697ebd Mon Sep 17 00:00:00 2001
From: Jun Pataleta <jun@moodle.com>
Date: Wed, 20 Sep 2023 15:39:46 +0200
Subject: [PATCH] MDL-79432 calendar: Deprecate unused functions

* calendar_get_link_previous() and calendar_get_link_next() are no
longer used anywhere except from the already deprecated
calendar_top_controls() so we should deprecate these as well.
---
 calendar/lib.php     | 6 ++++++
 calendar/upgrade.txt | 5 ++++-
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/calendar/lib.php b/calendar/lib.php
index 3c29c642688..bd014951d6c 100644
--- a/calendar/lib.php
+++ b/calendar/lib.php
@@ -1936,6 +1936,7 @@ function calendar_get_link_href($linkbase, $d, $m, $y, $time = 0) {
 /**
  * Build and return a previous month HTML link, with an arrow.
  *
+ * @deprecated since Moodle 4.3
  * @param string $text The text label.
  * @param string|moodle_url $linkbase The URL stub.
  * @param int $d The number of the date.
@@ -1947,6 +1948,8 @@ function calendar_get_link_href($linkbase, $d, $m, $y, $time = 0) {
  * @return string HTML string.
  */
 function calendar_get_link_previous($text, $linkbase, $d, $m, $y, $accesshide = false, $time = 0) {
+    debugging(__FUNCTION__ . ' has been deprecated and should not be used anymore.', DEBUG_DEVELOPER);
+
     $href = calendar_get_link_href(new \moodle_url($linkbase), $d, $m, $y, $time);
 
     if (empty($href)) {
@@ -1964,6 +1967,7 @@ function calendar_get_link_previous($text, $linkbase, $d, $m, $y, $accesshide =
 /**
  * Build and return a next month HTML link, with an arrow.
  *
+ * @deprecated since Moodle 4.3
  * @param string $text The text label.
  * @param string|moodle_url $linkbase The URL stub.
  * @param int $d the number of the Day
@@ -1975,6 +1979,8 @@ function calendar_get_link_previous($text, $linkbase, $d, $m, $y, $accesshide =
  * @return string HTML string.
  */
 function calendar_get_link_next($text, $linkbase, $d, $m, $y, $accesshide = false, $time = 0) {
+    debugging(__FUNCTION__ . ' has been deprecated and should not be used anymore.', DEBUG_DEVELOPER);
+
     $href = calendar_get_link_href(new \moodle_url($linkbase), $d, $m, $y, $time);
 
     if (empty($href)) {
diff --git a/calendar/upgrade.txt b/calendar/upgrade.txt
index 0c7298541cc..70bf4fb1a50 100644
--- a/calendar/upgrade.txt
+++ b/calendar/upgrade.txt
@@ -4,7 +4,10 @@ information provided here is intended especially for developers.
 === 4.3 ===
 * The `navigation` property has been removed from `\core_calendar\external\day_exporter` as it is not being used by any of the
   calendar templates.
-* calendar_top_controls() has been deprecated and should no longer be used.
+* The following functions have been deprecated and should no longer be used:
+  - calendar_top_controls()
+  - calendar_get_link_previous()
+  - calendar_get_link_next()
 
 === 4.1 ===
 * New method `calendar_format_event_location` which will format the location property of an event, converting any