From 801012aaaf3c8b98b62746a01391425ab311dd45 Mon Sep 17 00:00:00 2001 From: Jamie Pratt Date: Tue, 31 Jan 2012 15:32:13 +0700 Subject: [PATCH 1/2] MDL-47494 gapselect: NOBUG fixing unit tests related to change in default for hint format --- question/type/gapselect/simpletest/testquestiontype.php | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/question/type/gapselect/simpletest/testquestiontype.php b/question/type/gapselect/simpletest/testquestiontype.php index 4b81229978f..c3e14acd678 100755 --- a/question/type/gapselect/simpletest/testquestiontype.php +++ b/question/type/gapselect/simpletest/testquestiontype.php @@ -180,11 +180,11 @@ class qtype_gapselect_test extends UnitTestCase { Gamma 1 - + Try again. - + These are the first three letters of the Greek alphabet. @@ -228,7 +228,6 @@ class qtype_gapselect_test extends UnitTestCase { 'format' => FORMAT_MOODLE, 'files' => array())); $expectedq->hintshownumcorrect = array(true, true); $expectedq->hintclearwrong = array(false, true); - $this->assert(new CheckSpecifiedFieldsExpectation($expectedq), $q); $this->assertEqual($expectedq->hint, $q->hint); } From f37cb12ed0c06f159282137eedd332beeed949a7 Mon Sep 17 00:00:00 2001 From: Jamie Pratt Date: Tue, 31 Jan 2012 18:01:58 +0700 Subject: [PATCH 2/2] MDL-47494 gapselect: NOBUG change to string identifiers --- question/type/gapselect/lang/en/qtype_gapselect.php | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/question/type/gapselect/lang/en/qtype_gapselect.php b/question/type/gapselect/lang/en/qtype_gapselect.php index fd25df2d39d..439a1002507 100755 --- a/question/type/gapselect/lang/en/qtype_gapselect.php +++ b/question/type/gapselect/lang/en/qtype_gapselect.php @@ -23,16 +23,17 @@ * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later */ -$string['addinggapselect'] = 'Adding a select missing words question'; $string['addmorechoiceblanks'] = 'Blanks for {no} more choices'; $string['answer'] = 'Answer'; $string['choices'] = 'Choices'; $string['choicex'] = 'Choice {no}'; $string['correctansweris'] = 'The correct answer is: {$a}'; -$string['editinggapselect'] = 'Editing a select missing words question'; -$string['gapselect'] = 'Select missing words'; -$string['gapselect_help'] = 'Type in some question text like "The [[1]] jumped over the [[2]]", then enter the possible words to go in gaps 1 and 2 underneath.'; -$string['gapselectsummary'] = 'Missing words in some text are filled in using dropdown menus.'; $string['group'] = 'Group'; $string['pleaseputananswerineachbox'] = 'Please put an answer in each box.'; +$string['pluginname'] = 'Select missing words'; +$string['pluginname_help'] = 'Type in some question text like "The [[1]] jumped over the [[2]]", then enter the possible words to go in gaps 1 and 2 underneath.'; +$string['pluginname_link'] = 'question/type/gapselect'; +$string['pluginnameadding'] = 'Adding a select missing words question'; +$string['pluginnameediting'] = 'Editing a select missing words question'; +$string['pluginnamesummary'] = 'Missing words in some text are filled in using dropdown menus.'; $string['shuffle'] = 'Shuffle';