From 52f512e5cf70d2ce14484e7d08c01c9125c44992 Mon Sep 17 00:00:00 2001
From: Meirza <meirza.arson@moodle.com>
Date: Wed, 8 Feb 2023 21:18:19 +0700
Subject: [PATCH] MDL-77348 mod_scorm: Added missing class properties

In PHP 8.2 and later, setting a value to an undeclared class property is
deprecated and emits a deprecation notice.
So we need to add missing class properties that still need to be declared.
---
 mod/scorm/tests/externallib_test.php | 24 ++++++++++++++++++++++++
 mod/scorm/tests/lib_test.php         | 24 ++++++++++++++++++++++++
 2 files changed, 48 insertions(+)

diff --git a/mod/scorm/tests/externallib_test.php b/mod/scorm/tests/externallib_test.php
index d0f618dad25..6713eb29539 100644
--- a/mod/scorm/tests/externallib_test.php
+++ b/mod/scorm/tests/externallib_test.php
@@ -38,6 +38,30 @@ require_once($CFG->dirroot . '/mod/scorm/lib.php');
  */
 class externallib_test extends externallib_advanced_testcase {
 
+    /** @var \stdClass course record. */
+    protected \stdClass $course;
+
+    /** @var \stdClass activity record. */
+    protected \stdClass $scorm;
+
+    /** @var \core\context\module context instance. */
+    protected \core\context\module $context;
+
+    /** @var \stdClass */
+    protected \stdClass $cm;
+
+    /** @var \stdClass user record. */
+    protected \stdClass $student;
+
+    /** @var \stdClass user record. */
+    protected \stdClass $teacher;
+
+    /** @var \stdClass a fieldset object, false or exception if error not found. */
+    protected \stdClass $studentrole;
+
+    /** @var \stdClass a fieldset object, false or exception if error not found. */
+    protected \stdClass $teacherrole;
+
     /**
      * Set up for every test
      */
diff --git a/mod/scorm/tests/lib_test.php b/mod/scorm/tests/lib_test.php
index 961f9a2d555..92453b73a37 100644
--- a/mod/scorm/tests/lib_test.php
+++ b/mod/scorm/tests/lib_test.php
@@ -45,6 +45,30 @@ require_once($CFG->dirroot . '/mod/scorm/lib.php');
  */
 class lib_test extends \advanced_testcase {
 
+    /** @var \stdClass course record. */
+    protected \stdClass $course;
+
+    /** @var \stdClass activity record. */
+    protected \stdClass $scorm;
+
+    /** @var \core\context\module context instance. */
+    protected \core\context\module $context;
+
+    /** @var \stdClass */
+    protected \stdClass $cm;
+
+    /** @var \stdClass user record. */
+    protected \stdClass $student;
+
+    /** @var \stdClass user record. */
+    protected \stdClass $teacher;
+
+    /** @var \stdClass a fieldset object, false or exception if error not found. */
+    protected \stdClass $studentrole;
+
+    /** @var \stdClass a fieldset object, false or exception if error not found. */
+    protected \stdClass $teacherrole;
+
     /**
      * Set up for every test
      */