From 39ad2de97eef0400aedc57b7fc3dd9cf5291451e Mon Sep 17 00:00:00 2001 From: Andrew Nicols Date: Tue, 23 Mar 2021 08:03:36 +0800 Subject: [PATCH] MDL-69256 tests: Fix random slow test failures in completion cron --- lib/tests/completion_daily_task_test.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/tests/completion_daily_task_test.php b/lib/tests/completion_daily_task_test.php index e694ac06604..263b92d67af 100644 --- a/lib/tests/completion_daily_task_test.php +++ b/lib/tests/completion_daily_task_test.php @@ -114,10 +114,12 @@ class core_completion_cron_task_testcase extends advanced_testcase { // Get s1's completion record from c1. $s1c1 = $DB->get_record('course_completions', ['userid' => $s1->id, 'course' => $c1->id]); - $this->assertEquals(userdate($now), userdate($s1c1->timeenrolled)); + $this->assertGreaterThanOrEqual($now, $s1c1->timeenrolled); + $this->assertLessThanOrEqual(time(), $s1c1->timeenrolled); // Get s2's completion record from c1. $s2c1 = $DB->get_record('course_completions', ['userid' => $s2->id, 'course' => $c1->id]); - $this->assertEquals(userdate($now), userdate($s2c1->timeenrolled)); + $this->assertGreaterThanOrEqual($now, $s2c1->timeenrolled); + $this->assertLessThanOrEqual(time(), $s2c1->timeenrolled); } }