From 51bc030d19c6b1e8b318420eee76ecc1b96bcc54 Mon Sep 17 00:00:00 2001 From: Marina Glancy Date: Fri, 9 Mar 2018 12:01:32 +0800 Subject: [PATCH] MDL-60241 course: General section always visible (topics, weeks) --- course/format/topics/db/upgrade.php | 10 ++++++++++ course/format/topics/version.php | 2 +- course/format/weeks/db/upgrade.php | 10 ++++++++++ course/format/weeks/version.php | 2 +- 4 files changed, 22 insertions(+), 2 deletions(-) diff --git a/course/format/topics/db/upgrade.php b/course/format/topics/db/upgrade.php index 34841e14d51..3f35b53a2cb 100644 --- a/course/format/topics/db/upgrade.php +++ b/course/format/topics/db/upgrade.php @@ -49,5 +49,15 @@ function xmldb_format_topics_upgrade($oldversion) { // Automatically generated Moodle v3.4.0 release upgrade line. // Put any upgrade step following this. + if ($oldversion < 2018030900) { + + // During upgrade to Moodle 3.3 it could happen that general section (section 0) became 'invisible'. + // It should always be visible. + $DB->execute("UPDATE {course_sections} SET visible=1 WHERE visible=0 AND section=0 AND course IN + (SELECT id FROM {course} WHERE format=?)", ['topics']); + + upgrade_plugin_savepoint(true, 2018030900, 'format', 'topics'); + } + return true; } diff --git a/course/format/topics/version.php b/course/format/topics/version.php index ea6ecd4ca60..aa7210fbab6 100644 --- a/course/format/topics/version.php +++ b/course/format/topics/version.php @@ -25,6 +25,6 @@ defined('MOODLE_INTERNAL') || die(); -$plugin->version = 2017111300; // The current plugin version (Date: YYYYMMDDXX). +$plugin->version = 2018030900; // The current plugin version (Date: YYYYMMDDXX). $plugin->requires = 2017110800; // Requires this Moodle version. $plugin->component = 'format_topics'; // Full name of the plugin (used for diagnostics). diff --git a/course/format/weeks/db/upgrade.php b/course/format/weeks/db/upgrade.php index 1600c73f8d6..a68f7139840 100644 --- a/course/format/weeks/db/upgrade.php +++ b/course/format/weeks/db/upgrade.php @@ -85,5 +85,15 @@ function xmldb_format_weeks_upgrade($oldversion) { // Automatically generated Moodle v3.4.0 release upgrade line. // Put any upgrade step following this. + if ($oldversion < 2018030900) { + + // During upgrade to Moodle 3.3 it could happen that general section (section 0) became 'invisible'. + // It should always be visible. + $DB->execute("UPDATE {course_sections} SET visible=1 WHERE visible=0 AND section=0 AND course IN + (SELECT id FROM {course} WHERE format=?)", ['weeks']); + + upgrade_plugin_savepoint(true, 2018030900, 'format', 'weeks'); + } + return true; } diff --git a/course/format/weeks/version.php b/course/format/weeks/version.php index dfe4e0c2dcc..3f1bb72506e 100644 --- a/course/format/weeks/version.php +++ b/course/format/weeks/version.php @@ -25,6 +25,6 @@ defined('MOODLE_INTERNAL') || die(); -$plugin->version = 2017111300; // The current plugin version (Date: YYYYMMDDXX). +$plugin->version = 2018030900; // The current plugin version (Date: YYYYMMDDXX). $plugin->requires = 2017110800; // Requires this Moodle version. $plugin->component = 'format_weeks'; // Full name of the plugin (used for diagnostics).