From 508f42e2f1d7b3110d3a70f1528beac71b0fb8e1 Mon Sep 17 00:00:00 2001
From: Damyon Wiese <damyon@moodle.com>
Date: Thu, 17 Jan 2013 12:09:36 +0800
Subject: [PATCH] MDL-37539 Assignment upgrade: Disable submission comments if
 allow notes was not enabled.

For advanced upload of files only - this setting was stored in var2.

Conflicts:

	mod/assign/submission/comments/locallib.php
---
 mod/assign/submission/comments/locallib.php | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/mod/assign/submission/comments/locallib.php b/mod/assign/submission/comments/locallib.php
index 1d9118653a1..addc3618c38 100644
--- a/mod/assign/submission/comments/locallib.php
+++ b/mod/assign/submission/comments/locallib.php
@@ -113,7 +113,12 @@ class assign_submission_comments extends assign_submission_plugin {
      * @return bool was it a success? (false will trigger a rollback)
      */
     public function upgrade_settings(context $oldcontext, stdClass $oldassignment, & $log) {
-        // first upgrade settings (nothing to do)
+        if ($oldassignment->assignmenttype == 'upload') {
+            // Disable if allow notes was not enabled.
+            if (!$oldassignment->var2) {
+                $this->disable();
+            }
+        }
         return true;
     }