From 5019e695883e5dc86cc0254c031422d61e2c1943 Mon Sep 17 00:00:00 2001
From: Mark Nelson <markn@moodle.com>
Date: Thu, 5 Jan 2017 13:45:42 +0800
Subject: [PATCH] MDL-57578 core_calendar: removed the function
 calendar_event_hook()

Part of MDL-55611 epic.
---
 calendar/classes/event.php | 49 --------------------------------------
 calendar/upgrade.txt       |  4 ++++
 2 files changed, 4 insertions(+), 49 deletions(-)

diff --git a/calendar/classes/event.php b/calendar/classes/event.php
index e3cb643a5d4..44640cb42f3 100644
--- a/calendar/classes/event.php
+++ b/calendar/classes/event.php
@@ -413,8 +413,6 @@ class event {
                 }
             }
 
-            // Hook for tracking added events.
-            self::calendar_event_hook('add_event', array($this->properties, $repeatedids));
             return true;
         } else {
 
@@ -483,8 +481,6 @@ class event {
                 $event->trigger();
             }
 
-            // Hook for tracking event updates.
-            self::calendar_event_hook('update_event', array($this->properties, $updaterepeated));
             return true;
         }
     }
@@ -541,8 +537,6 @@ class event {
                     $eventargs['other']['timestart'] = $event->timestart;
                     $event = \core\event\calendar_event_updated::create($eventargs);
                     $event->trigger();
-
-                    self::calendar_event_hook('update_event', array($event, false));
                 }
             }
         }
@@ -561,9 +555,6 @@ class event {
             }
         }
 
-        // Fire the event deleted hook.
-        self::calendar_event_hook('delete_event', array($this->properties->id, $deleterepeated));
-
         // If we need to delete repeated events then we will fetch them all and delete one by one.
         if ($deleterepeated && !empty($this->properties->repeatid) && $this->properties->repeatid > 0) {
             // Get all records where the repeatid is the same as the event being removed.
@@ -687,55 +678,15 @@ class event {
         if ($force === true || ($force !== false && $this->properties->visible == 0)) {
             // Make this event visible.
             $this->properties->visible = 1;
-            // Fire the hook.
-            self::calendar_event_hook('show_event', array($this->properties));
         } else {
             // Make this event hidden.
             $this->properties->visible = 0;
-            // Fire the hook.
-            self::calendar_event_hook('hide_event', array($this->properties));
         }
 
         // Update the database to reflect this change.
         return $DB->set_field('event', 'visible', $this->properties->visible, array('id' => $this->properties->id));
     }
 
-    /**
-     * Attempts to call the hook for the specified action should a calendar type
-     * by set $CFG->calendar, and the appopriate function defined
-     *
-     * @param string $action One of `update_event`, `add_event`, `delete_event`, `show_event`, `hide_event`
-     * @param array $args The args to pass to the hook, usually the event is the first element
-     * @return bool attempts to call event hook
-     */
-    public static function calendar_event_hook($action, array $args) {
-        global $CFG;
-        static $extcalendarinc;
-        if ($extcalendarinc === null) {
-            if (!empty($CFG->calendar)) {
-                if (is_readable($CFG->dirroot .'/calendar/'. $CFG->calendar .'/lib.php')) {
-                    include_once($CFG->dirroot .'/calendar/'. $CFG->calendar .'/lib.php');
-                    $extcalendarinc = true;
-                } else {
-                    debugging("Calendar lib file missing or not readable at /calendar/{$CFG->calendar}/lib.php.",
-                        DEBUG_DEVELOPER);
-                    $extcalendarinc = false;
-                }
-            } else {
-                $extcalendarinc = false;
-            }
-        }
-        if ($extcalendarinc === false) {
-            return false;
-        }
-        $hook = $CFG->calendar .'_'.$action;
-        if (function_exists($hook)) {
-            call_user_func_array($hook, $args);
-            return true;
-        }
-        return false;
-    }
-
     /**
      * Returns an event object when provided with an event id.
      *
diff --git a/calendar/upgrade.txt b/calendar/upgrade.txt
index 4a37e2c205b..bcec3ba3bb9 100644
--- a/calendar/upgrade.txt
+++ b/calendar/upgrade.txt
@@ -1,6 +1,10 @@
 This files describes API changes in /calendar/* ,
 information provided here is intended especially for developers.
 
+=== 3.3 ===
+* calendar_event_hook() has been removed. Developers should be using the Moodle events system to achieve this behaviour,
+  rather than using a hacky calendar specific implementation.
+
 === 3.2 ===
 * calendar_preferences_button() is now depreciated.  Calendar preferences have been moved to the user preferences page.