From 4f403bfdcadc14acd3a6404441c2ee1a65d5fcba Mon Sep 17 00:00:00 2001
From: Mihail Geshoski <mihail@moodle.com>
Date: Sat, 30 Oct 2021 00:48:55 +0800
Subject: [PATCH] MDL-72873 core_grades: Add tertiary nav in grader report
 preferences

---
 grade/report/grader/preferences.php      | 9 +--------
 grade/report/grader/preferences_form.php | 2 +-
 2 files changed, 2 insertions(+), 9 deletions(-)

diff --git a/grade/report/grader/preferences.php b/grade/report/grader/preferences.php
index 4b0fccc2c79..c20965c5c2a 100644
--- a/grade/report/grader/preferences.php
+++ b/grade/report/grader/preferences.php
@@ -48,7 +48,7 @@ require('preferences_form.php');
 $mform = new grader_report_preferences_form('preferences.php', compact('course'));
 
 // If data submitted, then process and store.
-if (!$mform->is_cancelled() && $data = $mform->get_data()) {
+if ($data = $mform->get_data()) {
     foreach ($data as $preference => $value) {
         if (substr($preference, 0, 6) !== 'grade_') {
             continue;
@@ -60,13 +60,6 @@ if (!$mform->is_cancelled() && $data = $mform->get_data()) {
             set_user_preference($preference, $value);
         }
     }
-
-    redirect($CFG->wwwroot . '/grade/report/grader/index.php?id='.$courseid); // message here breaks accessability and is sloooowww
-    exit;
-}
-
-if ($mform->is_cancelled()){
-    redirect($CFG->wwwroot . '/grade/report/grader/index.php?id='.$courseid);
 }
 
 print_grade_page_head($courseid, 'settings', 'grader', get_string('preferences', 'gradereport_grader'));
diff --git a/grade/report/grader/preferences_form.php b/grade/report/grader/preferences_form.php
index 241adf6c47e..c3af8f5edcd 100644
--- a/grade/report/grader/preferences_form.php
+++ b/grade/report/grader/preferences_form.php
@@ -190,7 +190,7 @@ class grader_report_preferences_form extends moodleform {
         $mform->setType('id', PARAM_INT);
         $mform->setDefault('id', $course->id);
 
-        $this->add_action_buttons();
+        $this->add_action_buttons(false);
     }
 
 /// perform some extra moodle validation