MDL-21655 big scary enrolment and roles improvements - see tacker for list of changes, includes other minor fixes too

auth/fc/auth.php

@@ -178,7 +178,7 @@ class auth_plugin_fc extends auth_plugin_base {
             return; //nothing to sync - creators not configured
         }
 
-        if ($roles = get_roles_with_capability('moodle/legacy:coursecreator', CAP_ALLOW)) {
+        if ($roles = get_archetype_roles('coursecreator')) {
             $creatorrole = array_shift($roles);      // We can only use one, let's use the first one
             $systemcontext = get_context_instance(CONTEXT_SYSTEM);