From 40da6b8f0c61c076ab713fa174eaa79efbd06675 Mon Sep 17 00:00:00 2001 From: Jun Pataleta Date: Fri, 18 Aug 2023 13:37:06 +0800 Subject: [PATCH 1/2] MDL-79060 course: Use course name for the course image link --- blocks/myoverview/templates/view-list.mustache | 2 +- blocks/myoverview/templates/view-summary.mustache | 2 +- course/templates/coursecard.mustache | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/blocks/myoverview/templates/view-list.mustache b/blocks/myoverview/templates/view-list.mustache index 7e89779b152..bfb1a539c58 100644 --- a/blocks/myoverview/templates/view-list.mustache +++ b/blocks/myoverview/templates/view-list.mustache @@ -45,7 +45,7 @@
- {{#str}}aria:courseimage, core_course{{/str}} + {{fullname}}
diff --git a/blocks/myoverview/templates/view-summary.mustache b/blocks/myoverview/templates/view-summary.mustache index 32ce2824256..50c6d2fc8ea 100644 --- a/blocks/myoverview/templates/view-summary.mustache +++ b/blocks/myoverview/templates/view-summary.mustache @@ -45,7 +45,7 @@
- {{#str}}aria:courseimage, core_course{{/str}} + {{fullname}}
diff --git a/course/templates/coursecard.mustache b/course/templates/coursecard.mustache index e9fcbb04a56..b72ee87e45f 100644 --- a/course/templates/coursecard.mustache +++ b/course/templates/coursecard.mustache @@ -39,7 +39,7 @@ data-course-id="{{{id}}}">
- {{#str}}aria:courseimage, core_course{{/str}} + {{fullname}}
@@ -58,8 +58,8 @@ {{> core_course/favouriteicon }} - {{#str}}aria:coursename, core_course{{/str}} - + {{#str}}aria:coursename, core_course{{/str}} + {{$coursename}}{{/coursename}}
From 4aeada159d238f96455b7c79bdeb5987b560ac58 Mon Sep 17 00:00:00 2001 From: Jun Pataleta Date: Tue, 5 Sep 2023 11:12:18 +0800 Subject: [PATCH 2/2] MDL-79060 course: Deprecate unused aria:courseimage lang string --- lang/en/course.php | 4 +++- lang/en/deprecated.txt | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/lang/en/course.php b/lang/en/course.php index 88d8b8a8b72..f0f6212af70 100644 --- a/lang/en/course.php +++ b/lang/en/course.php @@ -41,7 +41,6 @@ $string['activitydate:closes'] = 'Closes:'; $string['activitydate:opened'] = 'Opened:'; $string['activitydate:opens'] = 'Opens:'; $string['aria:coursecategory'] = 'Course category'; -$string['aria:courseimage'] = 'Course image'; $string['aria:courseshortname'] = 'Course short name'; $string['aria:coursename'] = 'Course name'; $string['aria:defaulttab'] = 'Default activities'; @@ -163,3 +162,6 @@ $string['targetlabelstudentgradetopassno'] = 'Student who is likely to meet the $string['targetlabelstudentgradetopassyes'] = 'Student at risk of not meeting the minimum grade to pass the course.'; $string['targetlabelteachingyes'] = 'Users with teaching capabilities who have access to the course'; $string['targetlabelteachingno'] = 'Courses at risk of not starting'; + +// Deprecated since Moodle 4.3. +$string['aria:courseimage'] = 'Course image'; diff --git a/lang/en/deprecated.txt b/lang/en/deprecated.txt index 022b43206b4..fa40723b4e6 100644 --- a/lang/en/deprecated.txt +++ b/lang/en/deprecated.txt @@ -95,3 +95,4 @@ makeavailablecmtitle,core dateintervaldayshoursmins,core_langconfig completiondefault,core_completion configcompletiondefault,core_completion +aria:courseimage,core_course