From 4de4e456a48bd0c7d514c7c021ca4ec318cb02d5 Mon Sep 17 00:00:00 2001
From: Paul Holden <paulh@moodle.com>
Date: Tue, 19 Nov 2024 09:15:13 +0000
Subject: [PATCH] MDL-80995 tool_mfa: final removal of deprecated renderer
 method.

---
 .upgradenotes/MDL-80995-2024111821514500.yml |  7 +++++
 admin/tool/mfa/classes/output/renderer.php   | 27 +++-----------------
 2 files changed, 10 insertions(+), 24 deletions(-)
 create mode 100644 .upgradenotes/MDL-80995-2024111821514500.yml

diff --git a/.upgradenotes/MDL-80995-2024111821514500.yml b/.upgradenotes/MDL-80995-2024111821514500.yml
new file mode 100644
index 00000000000..36c728b586a
--- /dev/null
+++ b/.upgradenotes/MDL-80995-2024111821514500.yml
@@ -0,0 +1,7 @@
+issueNumber: MDL-80995
+notes:
+  tool_mfa:
+    - message: >-
+        The previously deprecated `setup_factor` renderer method has been
+        removed
+      type: removed
diff --git a/admin/tool/mfa/classes/output/renderer.php b/admin/tool/mfa/classes/output/renderer.php
index 53fa18de407..55613186610 100644
--- a/admin/tool/mfa/classes/output/renderer.php
+++ b/admin/tool/mfa/classes/output/renderer.php
@@ -143,32 +143,11 @@ class renderer extends \plugin_renderer_base {
     }
 
     /**
-     * Returns the html section for factor setup
-     *
-     * @param object $factor object of the factor class
-     * @return string
      * @deprecated since Moodle 4.4
-     * @todo Final deprecation in Moodle 4.8 MDL-80995
      */
-    public function setup_factor(object $factor): string {
-        debugging('The method setup_factor() has been deprecated. The HTML derived from this method is no longer needed.
-            Similar HTML is now achieved as part of available_factors().', DEBUG_DEVELOPER);
-        $html = '';
-
-        $html .= html_writer::start_tag('div', ['class' => 'card']);
-
-        $html .= html_writer::tag('h4', $factor->get_display_name(), ['class' => 'card-header']);
-        $html .= html_writer::start_tag('div', ['class' => 'card-body']);
-        $html .= $factor->get_info();
-
-        $setupparams = ['action' => 'setup', 'factor' => $factor->name, 'sesskey' => sesskey()];
-        $setupurl = new \moodle_url('action.php', $setupparams);
-        $html .= $this->output->single_button($setupurl, $factor->get_setup_string());
-        $html .= html_writer::end_tag('div');
-        $html .= html_writer::end_tag('div');
-        $html .= '<br>';
-
-        return $html;
+    #[\core\attribute\deprecated(null, reason: 'It is no longer used', since: '4.4', mdl: 'MDL-79920', final: true)]
+    public function setup_factor(): void {
+        \core\deprecation::emit_deprecation_if_present([self::class, __FUNCTION__]);
     }
 
     /**