From 8fbb62c9bcde8ee0a28336ea089c93a43e7abafa Mon Sep 17 00:00:00 2001 From: Tim Hunt Date: Tue, 13 Aug 2013 14:26:30 +0100 Subject: [PATCH] MDL-41162 quiz view page: invalid HTML. We were sometimes outputting nested p tags. Change the outer one to a div. --- mod/quiz/renderer.php | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/mod/quiz/renderer.php b/mod/quiz/renderer.php index bc50a865ed6..42b1434a0a1 100644 --- a/mod/quiz/renderer.php +++ b/mod/quiz/renderer.php @@ -1083,14 +1083,13 @@ class mod_quiz_renderer extends plugin_renderer_base { } if ($viewobj->gradebookfeedback) { $resultinfo .= $this->heading(get_string('comment', 'quiz'), 3, 'main'); - $resultinfo .= '

'.$viewobj->gradebookfeedback. - "

\n"; + $resultinfo .= html_writer::div($viewobj->gradebookfeedback, 'quizteacherfeedback') . "\n"; } if ($viewobj->feedbackcolumn) { $resultinfo .= $this->heading(get_string('overallfeedback', 'quiz'), 3, 'main'); - $resultinfo .= html_writer::tag('p', + $resultinfo .= html_writer::div( quiz_feedback_for_grade($viewobj->mygrade, $quiz, $context), - array('class' => 'quizgradefeedback'))."\n"; + 'quizgradefeedback') . "\n"; } if ($resultinfo) {