From e57e5603855d3c55a9b131c97723975bca6f32e8 Mon Sep 17 00:00:00 2001
From: Paul Holden <paulh@moodle.com>
Date: Wed, 24 Apr 2024 20:52:32 +0100
Subject: [PATCH] MDL-81632 block_recentlyaccesseditems: deterministic item
 ordering.

Behat tests of this functionality could trigger the unlikely (in real
world usage) scenario where a user has an identical "timeaccess" value
for multiple course activities.

This led to random failures in said tests when the DB ordered items in
apparently random order, where the "timeaccess" value was equal.
---
 blocks/recentlyaccesseditems/classes/helper.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/blocks/recentlyaccesseditems/classes/helper.php b/blocks/recentlyaccesseditems/classes/helper.php
index d1ac05b74ba..61e215ca261 100644
--- a/blocks/recentlyaccesseditems/classes/helper.php
+++ b/blocks/recentlyaccesseditems/classes/helper.php
@@ -58,7 +58,7 @@ class helper {
                   FROM {block_recentlyaccesseditems} rai
                   JOIN {course} c ON c.id = rai.courseid
                  WHERE userid = :userid
-                 ORDER BY rai.timeaccess DESC";
+              ORDER BY rai.timeaccess DESC, rai.id DESC";
         $records = $DB->get_records_sql($sql, $paramsql);
         $order = 0;