From 4abef03b8b2e71abd32fe9056fcc011387cd60ef Mon Sep 17 00:00:00 2001
From: moodler <moodler>
Date: Fri, 22 Apr 2005 16:38:50 +0000
Subject: [PATCH] Optimisations for read posts

---
 mod/forum/lib.php | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/mod/forum/lib.php b/mod/forum/lib.php
index d0dd2116b11..96c1d99648f 100644
--- a/mod/forum/lib.php
+++ b/mod/forum/lib.php
@@ -3059,30 +3059,31 @@ function forum_tp_add_read_record($userid, $postid, $discussionid=-1, $forumid=-
         $readrecord->firstread = time();
         $readrecord->lastread = $readrecord->firstread;
         return insert_record('forum_read', $readrecord, true);
-    }
-    else {
+
+    } else {
         /// Update read record
         $readrecord = reset($readrecord);
         $readrecord->lastread = time();
 
+        $update = NULL;
+        $update->id = $readrecord->id;
+        $update->lastread = $readrecord->lastread;
+
         /// This shouldn't happen, but just in case...
         if (!$readrecord->firstread) {
-            $readrecord->firstread = $readrecord->lastread;
             /// Update the 'firstread' field.
-            set_field('forum_read', 'firstread', $readrecord->firstread, 'userid', $userid, 'postid', $postid);
+            $update->firstread = $readrecord->lastread;
         }
         if ($discussionid > -1) {
             /// Update the 'discussionid' field.
-            set_field('forum_read', 'discussionid', $discussionid, 'userid', $userid, 'postid', $postid);
+            $update->discussionid = $discussionid;
         }
         if ($forumid > -1) {
             /// Update the 'forumid' field.
-            set_field('forum_read', 'forumid', $forumid, 'userid', $userid, 'postid', $postid);
+            $update->forumid = $discussionid;
         }
 
-        $readrecord->forumid = $forumid;
-        /// Update the 'lastread' field.
-        return set_field('forum_read', 'lastread', $readrecord->lastread, 'userid', $userid, 'postid', $postid);
+        return update_record('forum_read', $update);
     }
 }