From 48adc21e713daf219bfd3f0a971f9cbde90e7fa1 Mon Sep 17 00:00:00 2001 From: "Eloy Lafuente (stronk7)" Date: Tue, 14 Sep 2021 23:21:25 +0200 Subject: [PATCH] MDL-72589 behat: Add @skip_chrome_zerosize to failing scenarios All the scenarios failing with Chrome zero-size errors are getting the @skip_chrome_zerosize to be able to keep them apart from regular runs. See MDL-71108 for more information about that error. They will be run by another job, specifically using that tag to keep them failing and under control. --- .../behat/access_visible_cohorts.feature | 6 +++--- .../tests/behat/upload_cohort_users.feature | 2 +- .../grader/tests/behat/switch_views.feature | 2 +- .../behat/grade_calculated_weights.feature | 20 +++++++++---------- group/tests/behat/delete_groups.feature | 2 +- group/tests/behat/update_groups.feature | 2 +- .../behat/bulk_remove_submissions.feature | 6 +++--- .../tests/behat/remove_submission.feature | 6 +++--- mod/quiz/tests/behat/add_quiz.feature | 2 +- user/tests/behat/enrol_cohort_list.feature | 2 +- user/tests/behat/filter_participants.feature | 2 +- 11 files changed, 26 insertions(+), 26 deletions(-) diff --git a/cohort/tests/behat/access_visible_cohorts.feature b/cohort/tests/behat/access_visible_cohorts.feature index 5ee8c959cff..7f6282bd6a6 100644 --- a/cohort/tests/behat/access_visible_cohorts.feature +++ b/cohort/tests/behat/access_visible_cohorts.feature @@ -44,7 +44,7 @@ Feature: Access visible and hidden cohorts | user | course | role | | teacher | C1 | editingteacher | - @javascript + @javascript @skip_chrome_zerosize Scenario: Teacher can see visible cohorts defined in the above contexts When I log in as "teacher" And I am on "Course 1" course homepage @@ -74,7 +74,7 @@ Feature: Access visible and hidden cohorts And the "Select members from cohort" select box should not contain "Cohort empty in category 1" And the "Select members from cohort" select box should not contain "System empty cohort" - @javascript + @javascript @skip_chrome_zerosize Scenario: System manager can see all cohorts defined in the above contexts When I log in as "user1" And I am on "Course 1" course homepage @@ -103,7 +103,7 @@ Feature: Access visible and hidden cohorts And the "Select members from cohort" select box should not contain "Cohort empty in category 1" And the "Select members from cohort" select box should not contain "System empty cohort" - @javascript + @javascript @skip_chrome_zerosize Scenario: Category manager can see all cohorts defined in his category and visible cohorts defined above When I log in as "user2" And I am on "Course 1" course homepage diff --git a/cohort/tests/behat/upload_cohort_users.feature b/cohort/tests/behat/upload_cohort_users.feature index 931dec37ac5..a62ca76cf0a 100644 --- a/cohort/tests/behat/upload_cohort_users.feature +++ b/cohort/tests/behat/upload_cohort_users.feature @@ -4,7 +4,7 @@ Feature: Upload users to a cohort As an admin I need to upload a file with users data containing cohort assigns - @javascript + @javascript @skip_chrome_zerosize Scenario: Upload users and assign them to a course with cohort enrolment method enabled Given the following "cohorts" exist: | name | idnumber | diff --git a/grade/report/grader/tests/behat/switch_views.feature b/grade/report/grader/tests/behat/switch_views.feature index 388bdee64fd..14eb04ccf8c 100644 --- a/grade/report/grader/tests/behat/switch_views.feature +++ b/grade/report/grader/tests/behat/switch_views.feature @@ -78,7 +78,7 @@ Feature: We can change what we are viewing on the grader report | -1- | -4- | -5- | | Student 1 | 80 | 90 | - @javascript + @javascript @skip_chrome_zerosize Scenario: View and minimise the grader report containing hidden activities without the 'moodle/grade:viewhidden' capability When I am on "Course 1" course homepage with editing mode on And I open "Test assignment name 2" actions menu diff --git a/grade/tests/behat/grade_calculated_weights.feature b/grade/tests/behat/grade_calculated_weights.feature index 6d5826819d5..72fee663783 100644 --- a/grade/tests/behat/grade_calculated_weights.feature +++ b/grade/tests/behat/grade_calculated_weights.feature @@ -57,7 +57,7 @@ Feature: We can understand the gradebook user report And I click on "Move" "link" in the "EN Test assignment four" "table_row" And I click on "Move to here" "link" in the "//tbody//tr[position()=last()-3]" "xpath_element" - @javascript + @javascript @skip_chrome_zerosize Scenario: Mean of grades aggregation And I set the following settings for grade item "Course 1": | Aggregation | Mean of grades | @@ -74,7 +74,7 @@ Feature: We can understand the gradebook user report | EN Test assignment five | 33.33 % | 70.00 | 5.83 % | | EN Test assignment six | 33.33 % | 30.00 | 2.50 % | - @javascript + @javascript @skip_chrome_zerosize Scenario: Weighted mean of grades aggregation And I set the following settings for grade item "Course 1": | Aggregation | Weighted mean of grades | @@ -99,7 +99,7 @@ Feature: We can understand the gradebook user report | EN Test assignment five | 33.33 % | 70.00 | 4.67 % | | EN Test assignment six | 33.33 % | 30.00 | 2.00 % | - @javascript + @javascript @skip_chrome_zerosize Scenario: Simple weighted mean of grades aggregation And I set the following settings for grade item "Course 1": | Aggregation | Simple weighted mean of grades | @@ -120,7 +120,7 @@ Feature: We can understand the gradebook user report | EN Test assignment five | 33.33 % | 70.00 | 7.78 % | | EN Test assignment six | 33.33 % | 30.00 | 3.33 % | - @javascript + @javascript @skip_chrome_zerosize Scenario: Mean of grades (with extra credits) aggregation And I set the following settings for grade item "Course 1": | Aggregation | Mean of grades (with extra credits) | @@ -139,7 +139,7 @@ Feature: We can understand the gradebook user report | EN Test assignment five | 33.33 % | 70.00 | 7.78 % | | EN Test assignment six | 33.33 % | 30.00 | 3.33 % | - @javascript + @javascript @skip_chrome_zerosize Scenario: Median of grades aggregation And I set the following settings for grade item "Course 1": | Aggregation | Median of grades | @@ -156,7 +156,7 @@ Feature: We can understand the gradebook user report | EN Test assignment five | 33.33 % | 70.00 | 11.67 % | | EN Test assignment six | 33.33 % | 30.00 | 5.00 % | - @javascript + @javascript @skip_chrome_zerosize Scenario: Lowest grade aggregation And I set the following settings for grade item "Course 1": | Aggregation | Lowest grade | @@ -173,7 +173,7 @@ Feature: We can understand the gradebook user report | EN Test assignment five | 33.33 % | 70.00 | 0.00 % | | EN Test assignment six | 33.33 % | 30.00 | 0.00 % | - @javascript + @javascript @skip_chrome_zerosize Scenario: Highest grade aggregation And I set the following settings for grade item "Course 1": | Aggregation | Highest grade | @@ -190,7 +190,7 @@ Feature: We can understand the gradebook user report | EN Test assignment five | 33.33 % | 70.00 | 0.00 % | | EN Test assignment six | 33.33 % | 30.00 | 0.00 % | - @javascript + @javascript @skip_chrome_zerosize Scenario: Mode of grades aggregation And I set the following settings for grade item "Course 1": | Aggregation | Mode of grades | @@ -207,7 +207,7 @@ Feature: We can understand the gradebook user report | EN Test assignment five | 33.33 % | 70.00 | 0.00 % | | EN Test assignment six | 33.33 % | 30.00 | 0.00 % | - @javascript + @javascript @skip_chrome_zerosize Scenario: View user report with mixed aggregation methods And I set the following settings for grade item "Course 1": | Aggregation | Natural | @@ -230,7 +230,7 @@ Feature: We can understand the gradebook user report | EN Sub category totalWeighted mean of grades. | 33.33 % | 36.67 | - | | Course total | - | 156.67 | - | - @javascript + @javascript @skip_chrome_zerosize Scenario: View user report with natural aggregation And I set the following settings for grade item "EN Test assignment three": | Extra credit | 1 | diff --git a/group/tests/behat/delete_groups.feature b/group/tests/behat/delete_groups.feature index 9c89d407d5e..380b7f4b648 100644 --- a/group/tests/behat/delete_groups.feature +++ b/group/tests/behat/delete_groups.feature @@ -56,7 +56,7 @@ Feature: Automatic deletion of groups and groupings And I press "Yes" And I should not see "Grouping (with ID)" - @javascript + @javascript @skip_chrome_zerosize Scenario: Delete groups and groupings with and without ID numbers without the 'moodle/course:changeidnumber' capability Given I log out And I log in as "admin" diff --git a/group/tests/behat/update_groups.feature b/group/tests/behat/update_groups.feature index 9d6c53066b2..51ffb45c6cb 100644 --- a/group/tests/behat/update_groups.feature +++ b/group/tests/behat/update_groups.feature @@ -63,7 +63,7 @@ Feature: Automatic updating of groups and groupings And I click on "Edit" "link" in the "Grouping (with ID) (updated)" "table_row" And the field "idnumber" matches value "An ID (updated)" - @javascript + @javascript @skip_chrome_zerosize Scenario: Update groups and groupings with ID numbers without the 'moodle/course:changeidnumber' capability Given I log out And I log in as "admin" diff --git a/mod/assign/tests/behat/bulk_remove_submissions.feature b/mod/assign/tests/behat/bulk_remove_submissions.feature index 813f6a9bab9..76a09b95420 100644 --- a/mod/assign/tests/behat/bulk_remove_submissions.feature +++ b/mod/assign/tests/behat/bulk_remove_submissions.feature @@ -22,7 +22,7 @@ Feature: Bulk remove submissions | name | course | idnumber | | Group 1 | C1 | G1 | - @javascript + @javascript @skip_chrome_zerosize Scenario: Bulk remove submissions should remove the data that was submitted Given the following "activity" exists: | activity | assign | @@ -81,7 +81,7 @@ Feature: Bulk remove submissions And I set the field "selectall" to "1" Then I should not see "Remove submission" in the "Choose operation" "select" - @javascript + @javascript @skip_chrome_zerosize Scenario: Notification should be displayed when non-group users are selected for submission bulk removal in separate group mode Given the following "activity" exists: @@ -116,7 +116,7 @@ Feature: Bulk remove submissions And I should see "The submission of Student 1 cannot be removed" And I should see "The submission of Student 2 cannot be removed" - @javascript + @javascript @skip_chrome_zerosize Scenario: Bulk remove submission when group users are added to the bulk removing submissions process in separate group mode Given the following "group members" exist: diff --git a/mod/assign/tests/behat/remove_submission.feature b/mod/assign/tests/behat/remove_submission.feature index 3ad50cacb90..cf5149bea39 100644 --- a/mod/assign/tests/behat/remove_submission.feature +++ b/mod/assign/tests/behat/remove_submission.feature @@ -31,7 +31,7 @@ Feature: Remove a submission | student1 | G1 | | student2 | G1 | - @javascript + @javascript @skip_chrome_zerosize Scenario: Remove a submission should remove the data that was submitted Given the following "activity" exists: | activity | assign | @@ -56,7 +56,7 @@ Feature: Remove a submission And I am on the "Test assignment name" Activity page logged in as student1 And I should not see "I'm the student submission" - @javascript + @javascript @skip_chrome_zerosize Scenario: Remove a group submission should remove the data from all group members Given the following "activity" exists: | activity | assign | @@ -82,7 +82,7 @@ Feature: Remove a submission And I am on the "Test assignment name" Activity page logged in as student2 And I should not see "I'm the student submission" - @javascript + @javascript @skip_chrome_zerosize Scenario: A student can remove their own submission Given the following "activity" exists: | activity | assign | diff --git a/mod/quiz/tests/behat/add_quiz.feature b/mod/quiz/tests/behat/add_quiz.feature index cc7b685c81f..021a71820aa 100644 --- a/mod/quiz/tests/behat/add_quiz.feature +++ b/mod/quiz/tests/behat/add_quiz.feature @@ -39,7 +39,7 @@ Feature: Add a quiz And I should see "Answer saved" And I press "Submit all and finish" - @javascript + @javascript @skip_chrome_zerosize Scenario: Add and configure small quiz and perform an attempt as a student with Javascript enabled Then I click on "Submit all and finish" "button" in the "Confirmation" "dialogue" And I should see "So you think it is true" diff --git a/user/tests/behat/enrol_cohort_list.feature b/user/tests/behat/enrol_cohort_list.feature index f19813c045e..17acd891676 100644 --- a/user/tests/behat/enrol_cohort_list.feature +++ b/user/tests/behat/enrol_cohort_list.feature @@ -15,7 +15,7 @@ Feature: Viewing the list of cohorts to enrol in a course | user | course | role | | teacher1 | C1 | editingteacher | - @javascript + @javascript @skip_chrome_zerosize Scenario: Check the teacher does not see the cohorts field without the proper capabilities Given the following "cohort" exists: | name | Test cohort name | diff --git a/user/tests/behat/filter_participants.feature b/user/tests/behat/filter_participants.feature index 50343b1223c..e3c1e511f72 100644 --- a/user/tests/behat/filter_participants.feature +++ b/user/tests/behat/filter_participants.feature @@ -741,7 +741,7 @@ Feature: Course participants can be filtered Then I should see "Nothing to display" - @javascript + @javascript @skip_chrome_zerosize Scenario: Filter by user identity fields when cannot see the field data Given I log in as "admin" And I set the following system permissions of "Teacher" role: